style: Adjusted style for clippy.

Author: schmidmt

benches/vonmises.rs

@@ -1,17 +1,14 @@
 use criterion::black_box;
-use criterion::measurement::WallTime;
 use criterion::AxisScale;
 use criterion::BatchSize;
 use criterion::BenchmarkId;
 use criterion::Criterion;
 use criterion::PlotConfiguration;
-use criterion::Throughput;
 use criterion::{criterion_group, criterion_main};
 use rand::Rng;
 use rv::dist::VonMises;
 use rv::misc::bessel::log_i0;
 use rv::prelude::*;
-use rv::traits::*;
 use std::f64::consts::PI;
 
 fn bench_vm_draw(c: &mut Criterion) {

examples/betaprime_sbc.rs

@@ -1,4 +1,3 @@
-use rv::dist::BetaPrime;
 
 #[cfg(feature = "experimental")]
 use rand::SeedableRng;
@@ -8,7 +7,6 @@ use rand_xoshiro::Xoshiro256Plus;
 use rv::experimental::stick_breaking_process::{
     StickBreaking, StickBreakingDiscrete, StickBreakingDiscreteSuffStat,
 };
-use rv::prelude::*;
 
 // Simulation-based calibration
 // For details see http://www.stat.columbia.edu/~gelman/research/unpublished/sbc.pdf

examples/sbd.rs

@@ -1,5 +1,3 @@
-use rand::SeedableRng;
-use rv::prelude::*;
 
 #[cfg(feature = "experimental")]
 use rv::experimental::stick_breaking_process::{

examples/stickbreaking_posterior.rs

@@ -1,6 +1,3 @@
-use itertools::Either;
-use peroxide::statistics::stat::Statistics;
-use rv::prelude::*;
 
 #[cfg(feature = "experimental")]
 use rv::experimental::stick_breaking_process::*;

src/data/mod.rs

@@ -386,8 +386,8 @@ mod tests {
         fn impl_bool_into_bool() {
             let t = true;
             let f = false;
-            assert_eq!(t.into_bool(), true);
-            assert_eq!(f.into_bool(), false);
+            assert!(t.into_bool());
+            assert!(!f.into_bool());
         }
 
         #[test]

src/dist/betaprime.rs

@@ -10,6 +10,9 @@ use std::f64;
 use std::fmt;
 use std::sync::OnceLock;
 
+#[cfg(feature = "experimental")]
+use super::UnitPowerLaw;
+
 /// [Beta prime distribution](https://en.wikipedia.org/wiki/Beta_prime_distribution),
 /// BetaPrime(α, β) over x in (0, ∞).
 ///
@@ -277,18 +280,14 @@ impl Sampleable<f64> for BetaPrime {
     }
 }
 
-use crate::data::DataOrSuffStat;
 #[cfg(feature = "experimental")]
 use crate::experimental::stick_breaking_process::{
     StickBreakingDiscrete, StickBreakingDiscreteSuffStat,
 };
-use crate::traits::ConjugatePrior;
 
 #[cfg(feature = "experimental")]
 use crate::experimental::stick_breaking_process::StickBreaking;
 
-use crate::prelude::UnitPowerLaw;
-
 #[cfg(feature = "experimental")]
 impl Sampleable<StickBreakingDiscrete> for BetaPrime {
     fn draw<R: Rng>(&self, rng: &mut R) -> StickBreakingDiscrete {

src/dist/cdvm.rs

@@ -243,10 +243,7 @@ impl HasSuffStat<usize> for Cdvm {
         // TODO: Should we cache twopimu_over_m.cos() and twopimu_over_m.sin()?
 
         let (sin_twopimu_over_m, cos_twopimu_over_m) = twopimu_over_m.sin_cos();
-        self.kappa
-            * (stat.sum_cos() * cos_twopimu_over_m
-                + stat.sum_sin() * sin_twopimu_over_m)
-            - stat.n() as f64 * self.log_norm_const()
+        self.kappa.mul_add(stat.sum_cos().mul_add(cos_twopimu_over_m, stat.sum_sin() * sin_twopimu_over_m), -(stat.n() as f64 * self.log_norm_const()))
     }
 }
 

src/dist/normal_gamma/gaussian_prior.rs

@@ -78,7 +78,7 @@ impl ConjugatePrior<f64, Gaussian> for NormalGamma {
 
     fn ln_pp_cache(&self, x: &DataOrSuffStat<f64, Gaussian>) -> Self::PpCache {
         extract_stat_then(self, x, |stat| {
-            let params = posterior_from_stat(self, &stat);
+            let params = posterior_from_stat(self, stat);
             let PosteriorParameters { r, s, v, .. } = params;
 
             let half_v = v / 2.0;

src/dist/normal_inv_chi_squared/gaussian_prior.rs

@@ -88,15 +88,15 @@ impl ConjugatePrior<f64, Gaussian> for NormalInvChiSquared {
     ) -> f64 {
         extract_stat_then(self, x, |stat: &GaussianSuffStat| {
             let n = stat.n() as f64;
-            let post: Self = posterior_from_stat(self, &stat).into();
+            let post: Self = posterior_from_stat(self, stat).into();
             let lnz_n = post.ln_z();
             n.mul_add(-HALF_LN_PI, lnz_n - cache)
         })
     }
 
     fn ln_pp_cache(&self, x: &DataOrSuffStat<f64, Gaussian>) -> Self::PpCache {
         extract_stat_then(self, x, |stat: &GaussianSuffStat| {
-            let post = posterior_from_stat(self, &stat);
+            let post = posterior_from_stat(self, stat);
             let kn = post.kn;
             let vn = post.vn;
 

src/dist/scaled_prior.rs

@@ -171,7 +171,7 @@ where
         stat: &ScaledSuffStat<Fx::Stat>,
     ) -> Self::Posterior {
         ScaledPrior::new_unchecked(
-            self.parent.posterior_from_suffstat(&stat.parent()),
+            self.parent.posterior_from_suffstat(stat.parent()),
             self.scale,
         )
     }