Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Add data for additional shares bought to the FpmmTransaction entity #176

@Mi-Lan

Description

@Mi-Lan
  • We have problem when user deposits liquidity in market that has unequal number of shares in that those additionalShares bought are not registered anywhere on the subgraph and we have to calculate value of those shares bought in the front since we have additionalShares already

Requirements and considerations:

  1. Along with additionalShares that we already have we need value of those shares bought in collateral of the market(eth,dai...)

  2. Also we need to subtract value of those additional shares bought from the liquidity transaction value that it originated from so we are accurate, currently I do that in the front

  3. It would be great if those additional shares bought are registered as transactions in it of themselves so that we can keep pagination consistent it terms of how many items it can display on one page. Since If I get 5 transactions from subgraph and 3 of them are liquidity ones (with additional shares) I will have to display 8 transaction in the history table. And get 2 liquidity and 3 normal in next page it will be 7 transactions. Other reason is that I don't have to do any sorting in the front...

  4. Would be great if we can maybe convert cpk addresses to user addresses so we don't have to do it in front. Hexyl and I did some hacky solution that doesn't seem the best way? Dunno if it even makes sense to do it on subgraph but worth considering...

Screenshot 2021-06-30 at 13 47 36

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions