-
Notifications
You must be signed in to change notification settings - Fork 37
Open
Description
Expected Behavior:
a PROS project, with IS_LIBRARY set to 1, should include all files specified in TEMPLATE_FILES regardless of whether those files are from another template
Actual Behavior:
a PROS project, with IS_LIBRARY set to 1, does not include files which are part of a template installed in the project, even if explicitly set in TEMPLATE_FILES
Steps to reproduce:
- Create an empty PROS project named
dependency - Add
dependency.hfile in theincludedirectory - Add
dependency.htoTEMPLATE_FILESin - Set
IS_LIBRARYto1 - Set
LIBNAMEtodependency - Create
[email protected]throughpros make; pros make template - Run
pros c fetch [email protected]in the same directory as[email protected] - Create an empty PROS project named
template - Set
IS_LIBRARYto 1 - Set
LIBNAMEto template - Install
dependencyby runningpros c apply dependency - Delete
dependency.ain the firmware directory (see Issue 🐛Header-Only Templates Include Empty Binary #373 ) - Add
template.hto theincludedirectory - add
template.handdependency.htoTEMPLATE_FILES - create
[email protected]throughpros make; pros make template - Run
pros c fetch [email protected]in the same directory as[email protected] - Extract the zip file
- Observe dependency.h is not in the
includedirectory
System information:
Windows 11: Bug Reproduced
Linux (Ubuntu): Can't reproduce
macOS: Not Tested
PROS Version: 3.5.4
Additional Information
pros-cli/pros/cli/conductor_utils.py
Line 106 in d9cbbda
| exclude_files = exclude_files.union(project.list_template_files()) |
Metadata
Metadata
Assignees
Labels
No labels