fix lazy in create without filename (#979)

* fix lazy in create without filename

* fix Raster ambiguity

Author: rafaqz

src/array.jl

@@ -401,4 +401,4 @@ filekey(filename::String) = Symbol(splitext(basename(filename))[1])
 
 # Add a `dimconstructor` method so `AbstractProjected` lookups create a Raster
 # TODO this should be unwrapped to `DD.lookupconstructor` to avoid future ambiguities
-DD.dimconstructor(::Tuple{<:Dimension{<:AbstractProjected},Vararg{Dimension}}) = Raster
+DD.dimconstructor(::Tuple{<:Dimension{<:AbstractProjected},Vararg{Dimension}}) = Raster

src/create.jl

@@ -247,9 +247,11 @@ function create(filename::Nothing, types::NamedTuple, dims::Tuple;
     fill=nokw,
     layerdims=nokw,
     layermetadata=nokw,
+    lazy=false,
     f=identity,
     kw...
 )
+    lazy && throw(ArgumentError("`lazy` cannot be `true` without passing a `filename` keyword"))
     layerdims = isnokw(layerdims) ? map(_ -> basedims(dims), types) : layerdims
     layermetadata = layermetadata isa NamedTuple ? layermetadata : map(_ -> layermetadata, types)
     layerfill = fill isa NamedTuple ? fill : map(_ -> fill, types)
@@ -355,4 +357,4 @@ end
 
 _warn_keyword_not_used(label, obj) = @warn "`$label` of `$obj` found. But `chunks` are not used for in-memory rasters"
 _missingval_pair(missingval::Pair) = missingval
-_missingval_pair(missingval) = missingval => missingval
+_missingval_pair(missingval) = missingval => missingval

src/stack.jl

@@ -293,6 +293,7 @@ function RasterStack(layers::NamedTuple{K,<:Tuple{Vararg{AbstractDimArray}}};
     metadata=NoMetadata(),
     layermetadata::NamedTuple{K}=map(DD.metadata, _layers),
     layerdims::NamedTuple{K}=map(DD.basedims, _layers),
+    lazy=false,
     kw...
 ) where K
     data = map(parent, _layers)
@@ -682,7 +683,7 @@ function RasterStack(dt::AbstractDimTree; keep=nothing)
     end
 end
 # TODO resolve the meaning of Raster(::RasterStack)
-Raster(stack::AbstractDimStack) = cat(values(stack)...; dims=Band([keys(stack)...]))
+Raster(stack::AbstractDimStack; kw...) = Raster(cat(values(stack)...; dims=Band([keys(stack)...])); kw...)
 # In DD it would be 
 # Raster(st::AbstractDimStack) =
     # Raster([st[D] for D in DimIndices(st)]; dims=dims(st), metadata=metadata(st))
@@ -694,4 +695,4 @@ defaultmappedcrs(::Source, crs) = crs
 defaultmappedcrs(s::Source, ::NoKW) = defaultmappedcrs(s)
 defaultmappedcrs(::Source) = nothing
 
-check_multilayer_dataset(ds) = throw(ArgumentError("$(typeof(ds)) is not a multilayer raster dataset"))
+check_multilayer_dataset(ds) = throw(ArgumentError("$(typeof(ds)) is not a multilayer raster dataset"))

test/create.jl

@@ -128,6 +128,14 @@ end
         @test Rasters.name(st1) == (:c, :d)
         @test missingval(st1) === (c=0x00, d=Int16(1))
     end
+
+    @testset "lazy must have filename" begin
+        @test_throws ArgumentError Rasters.create((a=Int32, b=Float64, c=Bool), Extents.Extent(X=(0, 10), Y=(0, 5));
+            size=(X=1024, Y=1024),
+            lazy=true,
+        ) do st
+        end
+    end
 end
 
 ext = ".nc"

test/runtests.jl

@@ -74,4 +74,4 @@ using ZarrDatasets
         Aqua.test_unbound_args(ext)
         Aqua.test_undefined_exports(ext)
     end
-end
+end