Skip to content

Commit 345203a

Browse files
make chatbot configurations model selection not nullable (#1574)
* make chatbot configurations model selection not nullable * fix race condition in image uploading tests
1 parent d86361d commit 345203a

22 files changed

+117
-90
lines changed

services/headless-lms/chatbot/src/azure_chatbot.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ impl LLMRequest {
237237
let serialized_messages = serde_json::to_string(&api_chat_messages)?;
238238
let request_estimated_tokens = estimate_tokens(&serialized_messages);
239239

240-
let params = if let Some(true) = configuration.thinking_model {
240+
let params = if configuration.thinking_model {
241241
LLMRequestParams::Thinking(ThinkingParams {
242242
max_completion_tokens: Some(configuration.max_completion_tokens),
243243
reasoning_effort: Some(configuration.reasoning_effort),
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
ALTER TABLE chatbot_configurations
2+
ALTER COLUMN model_id DROP NOT NULL,
3+
ALTER COLUMN thinking_model DROP NOT NULL;
4+
5+
ALTER TABLE chatbot_configurations
6+
RENAME COLUMN model_id TO model;
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
ALTER TABLE chatbot_configurations
2+
ALTER COLUMN model
3+
SET NOT NULL,
4+
ALTER COLUMN thinking_model
5+
SET NOT NULL;
6+
7+
ALTER TABLE chatbot_configurations
8+
RENAME COLUMN model TO model_id;
Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)