Merge pull request #929 from rahuldkjain/dev

rahuldkjain · web-flow · commit 1932af0f9049 · 2025-10-15T21:15:06.000+05:30
Dev
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -3,8 +3,6 @@ name: Build and Deploy
 on:
   push:
     branches: [master, dev]
-  pull_request:
-    branches: [master, dev]
 
 # Allow concurrent deployments for different environments
 concurrency:
diff --git a/src/app/layout.tsx b/src/app/layout.tsx
@@ -80,6 +80,14 @@ export const metadata: Metadata = {
     creator: '@rahuldkjain',
     images: ['/og-image.png'],
   },
+  icons: {
+    icon: [
+      { url: '/favicon.ico', sizes: 'any' },
+      { url: '/mdg.png', type: 'image/png' },
+    ],
+    apple: '/mdg.png',
+  },
+  manifest: '/manifest.json',
   robots: {
     index: true,
     follow: true,
@@ -130,10 +138,7 @@ export default function RootLayout({
   return (
     <html lang="en" suppressHydrationWarning>
       <head>
-        <link rel="icon" href="/favicon.ico" sizes="any" />
-        <link rel="icon" href="/mdg.png" type="image/png" />
-        <link rel="apple-touch-icon" href="/mdg.png" />
-        <link rel="manifest" href="/manifest.json" />
+        {/* Favicon and manifest are now handled by Next.js metadata API above */}
         <meta name="theme-color" content="#000000" />
         <meta name="apple-mobile-web-app-capable" content="yes" />
         <meta name="apple-mobile-web-app-status-bar-style" content="default" />
diff --git a/src/components/layout/footer.tsx b/src/components/layout/footer.tsx
@@ -1,12 +1,22 @@
 import Link from 'next/link';
+import Image from 'next/image';
+
+// Import the logo as a static asset for GitHub Pages compatibility
+import logoImage from '../../images/mdg.png';
 
 export function Footer() {
   return (
     <footer className="border-border bg-card border-t py-8">
       <div className="container mx-auto px-4">
         {/* Logo Section */}
         <div className="mb-8 flex items-center justify-center gap-3">
-          <img src="/mdg.png" alt="GitHub Profile README Generator Logo" className="h-12 w-12" />
+          <Image
+            src={logoImage}
+            alt="GitHub Profile README Generator Logo"
+            width={48}
+            height={48}
+            className="h-12 w-12"
+          />
           <span className="text-xl font-bold">GitHub Profile README Generator</span>
         </div>
 
diff --git a/src/components/layout/header.tsx b/src/components/layout/header.tsx
@@ -7,6 +7,9 @@ import { ThemeToggle } from '@/components/ui/theme-toggle';
 import { AccessibilityMenu } from '@/components/ui/accessibility-menu';
 import { GitHubStats } from '@/components/ui/github-stats';
 
+// Import the logo as a static asset for GitHub Pages compatibility
+import logoImage from '../../images/mdg.png';
+
 const navigation = [
   { name: 'Generator', href: '/' },
   { name: 'Addons', href: '/addons' },
@@ -30,7 +33,7 @@ export function Header({}: HeaderProps = {}) {
           <div className="flex items-center gap-4">
             <Link href="/" prefetch={true} className="flex items-center gap-3 hover:opacity-80">
               <Image
-                src="/mdg.png"
+                src={logoImage}
                 alt="GitHub Profile README Generator Logo"
                 width={40}
                 height={40}
