Use CCCL's mdspan implementation #2836
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
3 tasks
bdice
commented
Oct 14, 2025
| }; | ||
|
|
||
| template <typename T1, typename T2> | ||
| template <typename T1, typename T2, typename DenseVectorView, typename ResultVectorView> |
Contributor
Author
There was a problem hiding this comment.
Need to check if this change is correct.
Contributor
Author
|
/ok to test |
mhoemmen
reviewed
Oct 14, 2025
mhoemmen
reviewed
Oct 14, 2025
mhoemmen
reviewed
Oct 14, 2025
mhoemmen
reviewed
Oct 14, 2025
mhoemmen
reviewed
Oct 14, 2025
mhoemmen
reviewed
Oct 14, 2025
mhoemmen
reviewed
Oct 14, 2025
mhoemmen
reviewed
Oct 14, 2025
mhoemmen
reviewed
Oct 14, 2025
This was referenced Oct 14, 2025
divyegala
reviewed
Oct 15, 2025
cjnolet
moved this from Todo
to In Progress
in Vector Search, ML, & Data Mining Release Board
Member
|
/ok to test f2b93f2 |
robertmaynard
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adopts CCCL's
mdspanimplementation and deletes the vendored implementation.Closes #1616.
We also introduce a breaking change by removing the default type for template parameter
ExtentType = std::uint32_tin all mdarray and mdspan related types, aliases, and functions.