Delayed tab change

[thomasdondorf]

Thanks again for this great library!

I notice that in Safari on iOS, the tab switch is delayed when using registerTabBarEffect. It is even visible in a video you made (in this issue):

Notice how when you click, the tab change is delayed for about half a second before actually changing the tab. It looks to me like it waits until the animation finishes, which is not what should happen. The page itself should switch immediately, but the animation in the tabbar might finish afterwards.

[rdlabo]

@thomasdondorf Thanks for the issue!
I’ve updated it so that clearActivated runs without waiting for the startAnimationPromise to finish.
Given the implementation of IonicGesture, I believe this is the fastest possible approach.

[thomasdondorf]

Thanks for being so responsive, much appreciated!

Now the switch is done instantly which is great, but the animation is broken. I guess it starts and then is immediately canceled?

Now, I have never used ionic gestures and don't know your code very well, but maybe it makes sense to instead of calling clearActivaited to call currentTouchedElement.click() (if that is how the gestures work, just guessing to be honest):

[rdlabo]

Thanks for the detailed feedback!

You're right — with the previous fix the tab switch happens instantly, but the animation was indeed being canceled. That was my oversight.

I've adjusted the implementation again so that the animation can run properly while the tab change still happens without delay.

Could you check it once more and let me know if it behaves better on your side?