Skip to content

Old version of GitHub workflow schema used #1142

@flying-sheep

Description

@flying-sheep

Describe the bug

GitHub used to not document their milestoned and demilestoned types for the pull_request event. Now both GitHub and schemastore include them as expected.

Still, on a workflow like this I see errors (see below).

name: 
on:
  pull_request:
    types:
      - milestoned
      - demilestoned
jobs: {}

Expected Behavior

No errors displayed

Current Behavior

Image

Steps to Reproduce

  1. create workflow with demilestoned or milestoned pull request event type

Environment

  • Windows
  • Mac
  • Linux
  • other (please specify)

Further detail

When I clean the cache and check the file, it is clearly the newest version!

rg -A 25 '"pull_request":' .config/Code/User/globalStorage/redhat.vscode-yaml/schemas_cache/00db8df54019c8e656b5f465c5efa835 
1348:            "pull_request": {
1349-              "$comment": "https://help.github.com/en/github/automating-your-workflow-with-github-actions/events-that-trigger-workflows#pull-request-event-pull_request",
1350-              "$ref": "#/definitions/ref",
1351-              "description": "Runs your workflow anytime the pull_request event occurs. More than one activity type triggers this event. For information about the REST API, see https://developer.github.com/v3/pulls.\nNote: Workflows do not run on private base repositories when you open a pull request from a forked repository.\nWhen you create a pull request from a forked repository to the base repository, GitHub sends the pull_request event to the base repository and no pull request events occur on the forked repository.\nWorkflows don't run on forked repositories by default. You must enable GitHub Actions in the Actions tab of the forked repository.\nThe permissions for the GITHUB_TOKEN in forked repositories is read-only. For more information about the GITHUB_TOKEN, see https://help.github.com/en/articles/virtual-environments-for-github-actions.",
1352-              "properties": {
1353-                "types": {
1354-                  "$ref": "#/definitions/types",
1355-                  "items": {
1356-                    "type": "string",
1357-                    "enum": [
1358-                      "assigned",
1359-                      "unassigned",
1360-                      "labeled",
1361-                      "unlabeled",
1362-                      "opened",
1363-                      "edited",
1364-                      "closed",
1365-                      "reopened",
1366-                      "synchronize",
1367-                      "converted_to_draft",
1368-                      "ready_for_review",
1369-                      "locked",
1370-                      "unlocked",
1371-                      "milestoned",
1372-                      "demilestoned",
1373-                      "review_requested",

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions