Fix pool idle connection counter bug

ofekshenawa · ofekshenawa · commit 990e0ec5d3b7 · 2025-12-03T15:29:59.000+02:00
diff --git a/internal/pool/pool.go b/internal/pool/pool.go
@@ -132,7 +132,6 @@ func GetMaintenanceNotificationCallback() func(ctx context.Context, cn *Conn, no
 	return maintenanceNotificationCallback
 }
 
-
 // Stats contains pool state information and accumulated stats.
 type Stats struct {
 	Hits           uint32 // number of times free connection was found in the pool
@@ -948,7 +947,6 @@ func (p *ConnPool) putConn(ctx context.Context, cn *Conn, freeTurn bool) {
 			p.connsMu.Unlock()
 			p.idleConnsLen.Add(1)
 		}
-		p.idleConnsLen.Add(1)
 
 		// Notify metrics: connection moved from used to idle
 		if connectionStateChangeCallback != nil {

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,6 @@ func GetMaintenanceNotificationCallback() func(ctx context.Context, cn *Conn, no`
`132`	`132`	`return maintenanceNotificationCallback`
`133`	`133`	`}`
`134`	`134`
`135`		`-`
`136`	`135`	`// Stats contains pool state information and accumulated stats.`
`137`	`136`	`type Stats struct {`
`138`	`137`	`Hits uint32 // number of times free connection was found in the pool`
`@@ -948,7 +947,6 @@ func (p ConnPool) putConn(ctx context.Context, cn Conn, freeTurn bool) {`
`948`	`947`	`p.connsMu.Unlock()`
`949`	`948`	`p.idleConnsLen.Add(1)`
`950`	`949`	`}`
`951`		`- p.idleConnsLen.Add(1)`
`952`	`950`
`953`	`951`	`// Notify metrics: connection moved from used to idle`
`954`	`952`	`if connectionStateChangeCallback != nil {`