Skip to content

Commit 9fc05bb

Browse files
committed
Fixing review remarks
1 parent d36c101 commit 9fc05bb

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@ A GitHub action that runs a phpcs and reports the result to reviewdog
44
# Prerequisites
55
* Composer install has been executed
66
* Phpcs is install by composer and available in the composer config bin-dir
7-
* The code styles used by phpcs are installed and confgured in phpcs.xml
7+
* The code styles used by phpcs are installed and confgured in the .phpcs.xml
88

99
# Usage
1010
Add a workflow step with the action:
1111

1212
```yaml
1313
steps:
1414
- name: Run phpcs
15-
uses: reload/poc-phpcs-reviewdog-action@<VERSION>
15+
uses: reload/action-phpcs@<VERSION>
1616
with:
1717
reviewdog_token: ${{ secrets.GITHUB_TOKEN }}`
1818
```
@@ -24,7 +24,7 @@ Example:
2424
```yaml
2525
steps:
2626
- name: Run phpcs
27-
uses: reload/poc-phpcs-reviewdog-action@<VERSION>
27+
uses: reload/action-phpcs@<VERSION>
2828
with:
2929
path: drupal
3030
reviewdog_token: ${{ secrets.GITHUB_TOKEN }}`

action.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,9 @@ runs:
2121
run: |
2222
set +o pipefail
2323
24-
# Change directory to where phpcs should do its thing.
2524
cd ${{ inputs.path }}
2625
27-
# No warnings errors/warnings on exit from phpcs please.
26+
# No warnings errors/warnings since it breaks the connection to reviewdog.
2827
$(composer config bin-dir)/phpcs --config-set ignore_errors_on_exit 1
2928
$(composer config bin-dir)/phpcs --config-set ignore_warnings_on_exit 1
3029

0 commit comments

Comments
 (0)