chore(github): warn users without "Automatically delete head branches" #38566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamietanna
commented
Oct 13, 2025
Comment on lines
+591
to
+592
| documentationUrl: | ||
| 'https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-the-automatic-deletion-of-branches', |
There was a problem hiding this comment.
I couldn't find us using documentationUrl before - is there any prior art?
There was a problem hiding this comment.
I don't think so, but we should IMO link only our documentation
There was a problem hiding this comment.
Do you think linking to GitHub's official docs will be an issue? Are you concerned about URLs breaking in the future? Or perhaps more that we should "only" try and point to things that we own? (And avoiding a precedent being set, where someone may then think this can be any arbitrary docs?
jamietanna
force-pushed
the
feat/warn-on-no-delete
branch
from
ffe673e to
93f1283
Compare
As noted in #38324, there could be a bug occur with branches not being automagically deleted, where: 1. repository does not "Automatically delete head branches" 1. `minimumReleaseAge` is used to gate a release update, as the release is not passing that check 1. a group that includes that release is set up 1. a branch is created for all updates except the `minimumReleaseAge` (as expected) 1. the PR is merged 1. the branch is not deleted 1. next time Renovate runs, it sees the branch created - albeit out of date - so it treats this as permission to update the package gated by `minimumReleaseAge` As a step towards fixing this long-term, we can introduce a log warning to inform repo owners that they may be susceptible to issues.
jamietanna
force-pushed
the
feat/warn-on-no-delete
branch
from
93f1283 to
2693ffe
Compare
| documentationUrl: | ||
| 'https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-the-automatic-deletion-of-branches', | ||
| }, | ||
| 'Repository does not have "Automatically delete head branches" set, which could cause Renovate to re-use a repository in some cases', |
There was a problem hiding this comment.
Suggested change
| 'Repository does not have "Automatically delete head branches" set, which could cause Renovate to re-use a repository in some cases', | |
| 'Repository does not have "Automatically delete head branches" set, which could cause Renovate to re-use a branch in some cases', |
secustor
reviewed
Oct 28, 2025
Comment on lines
+591
to
+592
| documentationUrl: | ||
| 'https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-the-automatic-deletion-of-branches', |
There was a problem hiding this comment.
I don't think so, but we should IMO link only our documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
As noted in #38324, there could be a bug occur with branches not being
automagically deleted, where:
minimumReleaseAgeis used to gate a release update, as the releaseis not passing that check
minimumReleaseAge(as expected)
date - so it treats this as permission to update the package gated by
minimumReleaseAgeAs a step towards fixing this long-term, we can introduce a log warning
to inform repo owners that they may be susceptible to issues.
Context
Please select one of the below:
Relates to #38325.
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: