Enable TestSingleNodeNetworkReport #3192
Conversation
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
e2e/install_test.go
Outdated
| allowedDomains := map[string]struct{}{ | ||
| "ec-e2e-proxy.testcluster.net": {}, | ||
| "ec-e2e-replicated-app.testcluster.net": {}, | ||
| "*": {}, |
There was a problem hiding this comment.
Bug: Wildcard Asterisk Fails Broad Domain Matching
Adding "*" to allowedDomains only matches domains literally named "*", not all domains. The map lookup at line 766 performs exact string matching, so this doesn't implement wildcard behavior. Any domain not exactly matching the three keys will still cause test failure.
e2e/install_test.go
Outdated
|
|
||
| //Temporarily disable network test until the reporting is enriched to the point where we can properly filter out domains as part of a CNAME chain | ||
| /*func TestSingleNodeNetworkReport(t *testing.T) { | ||
| // Temporarily disable network test until the reporting is enriched to the point where we can properly filter out domains as part of a CNAME chain |
There was a problem hiding this comment.
This comment is no longer true
e2e/install_test.go
Outdated
| allowedDomains := map[string]struct{}{ | ||
| "ec-e2e-proxy.testcluster.net": {}, | ||
| "ec-e2e-replicated-app.testcluster.net": {}, | ||
| "*": {}, |
There was a problem hiding this comment.
Can you add a comment in the code explaining that this is due to the preflight for wildcard dns entries
emosbaugh
deleted the
joshd/sc-130271/ec-network-report-test-verifies-domains-in
branch
* Enable TestSingleNodeNetworkReport * Adding * * w
What this PR does / why we need it:
Enables the test
TestSingleNodeNetworkReportand adds*as an allowed request, since there's a preflight request that sends a dns request for*.Which issue(s) this PR fixes:
https://app.shortcut.com/replicated/story/130271/ec-network-report-test-verifies-domains-in-docs
Does this PR require a test?
NONE
Does this PR require a release note?
Does this PR require documentation?
NONE