Skip to content

refactor: use frappe functionality of dialog box to show warning #3723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2025
Merged

refactor: use frappe functionality of dialog box to show warning #3723

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions india_compliance/gst_india/client_scripts/e_invoice_actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,7 @@ frappe.ui.form.on("Sales Invoice", {
if (frm.doc.docstatus === 0 || !is_einv_generatable) {
frm.add_custom_button(
__("Applicability Status"),
() =>
show_e_invoice_applicability_status(
frm,
is_einv_generatable
),
() => show_e_invoice_applicability_status(frm, is_einv_generatable),
"e-Invoice"
);

Expand Down Expand Up @@ -137,7 +133,12 @@ frappe.ui.form.on("Sales Invoice", {

Are you sure you want to continue?`
);
const d = frappe.warn(__("Cannot Cancel IRN"), message, continueCancellation, __("Yes"));
const d = frappe.warn(
__("Cannot Cancel IRN"),
message,
continueCancellation,
__("Yes")
);

d.set_secondary_action_label(__("No"));
return;
Expand Down Expand Up @@ -191,11 +192,11 @@ function show_cancel_e_invoice_dialog(frm, callback) {
india_compliance.primary_to_danger_btn(d);
d.show();

$(`
<div class="alert alert-warning" role="alert">
${__("Sales invoice will be cancelled along with the IRN.")}
</div>
`).prependTo(d.wrapper);
d.show_message(
__("Sales invoice will be cancelled along with the IRN."),
"yellow",
1 // permanent
);
}

function show_mark_e_invoice_as_generated_dialog(frm) {
Expand Down Expand Up @@ -287,7 +288,7 @@ function get_cancel_e_invoice_dialog_fields(frm, manual_cancel = false) {
default: manual_cancel
? "Others"
: gst_settings.reason_for_e_invoice_cancellation ||
"Data Entry Mistake",
"Data Entry Mistake",
options: ["Duplicate", "Data Entry Mistake", "Order Cancelled", "Others"],
},
{
Expand Down Expand Up @@ -396,7 +397,9 @@ function show_e_invoice_applicability_status(frm, is_einv_applicable) {
}

frappe.msgprint({
title: is_einv_applicable ? __("e-Invoice can be generated") : __("e-Invoice cannot be generated"),
title: is_einv_applicable
? __("e-Invoice can be generated")
: __("e-Invoice cannot be generated"),
message: frm._einv_message,
indicator: is_einv_applicable ? "green" : "red",
});
Expand Down