[Ingestion] ingestion-client crate
#3976
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 12, 2025
muhamadazmy
force-pushed
the
pr3976
branch
2 times, most recently
from
7dc9605 to
767c781
Compare
muhamadazmy
force-pushed
the
pr3976
branch
4 times, most recently
from
ea999cc to
5b488c7
Compare
muhamadazmy
changed the title
ingress-core crateingress-client crate
muhamadazmy
force-pushed
the
pr3976
branch
2 times, most recently
from
e9f749a to
484bced
Compare
This was referenced Nov 13, 2025
muhamadazmy
force-pushed
the
pr3976
branch
5 times, most recently
from
98d2099 to
6fcdd50
Compare
This was referenced Nov 17, 2025
Contributor
tillrohrmann
left a comment
tillrohrmann
left a comment
There was a problem hiding this comment.
Thanks a lot for creating this PR @muhamadazmy. The changes look really great :-) I left a few minor comments and questions around the handling of cancellations, the need for avoiding lock contention in the SessionManager and whether chunking based on bytes would be possible.
muhamadazmy
force-pushed
the
pr3976
branch
7 times, most recently
from
32dc18e to
e8839b2
Compare
muhamadazmy
changed the title
ingress-client crateingestion-client crate
muhamadazmy
force-pushed
the
pr3976
branch
2 times, most recently
from
ab0b964 to
9733625
Compare
- `ingestion-client` implements the runtime layer that receives WAL envelopes, fans it out to the correct partition, and tracks completion. It exposes: - `IngestionClient`, enforces inflight budgets, and resolves partition IDs before sending work downstream. - The session subsystem that batches `IngestRecords`, retries connections, and reports commit status to callers. - `ingestion-client` only ingests records and notify the caller once the record is "committed" to bifrost by the PP. This makes it useful to implement kafka ingress and other external ingestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Ingestion]
ingestion-clientcrateingestion-clientimplements the runtime layer that receives WAL envelopes, fans it out to the correct partition, and tracks completion. It exposes:IngestionClient, enforces inflight budgets, and resolves partition IDs before sending work downstream.IngestRecords, retries connections, and reports commit status to callers.ingestion-clientonly ingests records and notify the caller once the record is "committed" to bifrost by the PP. This makes it useful to implement kafka ingress and other external ingestionStack created with Sapling. Best reviewed with ReviewStack.
Shuffler#4024IngressClientfor invocation and state mgmt #3980ingress-client#3975IngestRequestmessage #3974CommitTokenback from notify_committed() #3968ingestion-clientcrate #3976