Updates

Author: rjcorwin

spec/scratch/MESSAGE-FORMATTERS.md

@@ -9,22 +9,30 @@ This document inventories which MEW protocol messages have dedicated formatters
 ### ✅ Implemented Formatters
 
 #### `chat`
-- **Location**: `src/cli/utils/interactive-ui.ts` (line ~770), `src/cli/utils/advanced-interactive-ui.ts` (line ~1900)
-- **Formatting**: 
+- **Location**: `src/cli/utils/advanced-interactive-ui.ts` (line ~1900)
+- **Formatting**:
   - Shows text content directly
-  - In advanced UI: Full-width separators (top/bottom borders) for visual distinction
+  - Full-width separators (top/bottom borders) for visual distinction
   - Filled diamond (◆) prefix
   - Theme-aware colors
 
+#### `chat/acknowledge`
+- **Location**: `src/cli/utils/advanced-interactive-ui.ts` (line ~2544)
+- **Formatting**:
+  - Checkmark (✓) prefix
+  - Shows status field from payload (e.g., "processing", "received", "seen")
+  - Example: `✓ processing` or `✓ received`
+  - Note: Per spec, payload only contains `status` field; correlation_id (in envelope) references acknowledged message
+
 #### `mcp/request` and `mcp/proposal`
-- **Location**: `src/cli/utils/interactive-ui.ts` (line ~775), `src/cli/utils/advanced-interactive-ui.ts` (line ~1920)
+- **Location**: `src/cli/utils/advanced-interactive-ui.ts` (line ~1920)
 - **Formatting**:
   - Shows method and tool name
   - Arguments preview
   - Special handling for `tools/call` with tool-specific formatters
 
 #### `mcp/response`
-- **Location**: `src/cli/utils/interactive-ui.ts` (line ~780), `src/cli/utils/advanced-interactive-ui.ts` (line ~1940)
+- **Location**: `src/cli/utils/advanced-interactive-ui.ts` (line ~1940)
 - **Formatting**:
   - Handles result content arrays (shows first text item)
   - Object results with key summary
@@ -44,13 +52,46 @@ This document inventories which MEW protocol messages have dedicated formatters
   - Prefixes: ◇ for start, ◆ for conclusion
   - Message preview (truncated to 120 chars)
 
+#### `stream/request`
+- **Location**: `src/cli/utils/advanced-interactive-ui.ts` (line ~2642)
+- **Formatting**:
+  - Shows direction (upload/download)
+  - Shows description if present
+  - Shows expected size in MB if present
+  - Example: `upload stream "reasoning:reason-123"` or `download stream (5.2MB)`
+
+#### `stream/open`
+- **Location**: `src/cli/utils/advanced-interactive-ui.ts` (line ~2649)
+- **Formatting**:
+  - Shows stream ID and encoding
+  - Example: `opened stream-4 [text]` or `opened stream-42 [binary]`
+
+#### `stream/close`
+- **Location**: `src/cli/utils/advanced-interactive-ui.ts` (line ~2655)
+- **Formatting**:
+  - Shows stream ID (if present) and reason
+  - Example: `stream-4 complete` or `cancelled`
+
 #### `system/help`
 - **Location**: `src/cli/utils/advanced-interactive-ui.ts` (line ~1970)
 - **Formatting**:
   - Multi-line display with proper indentation
   - Section titles highlighted
   - Line-by-line rendering
 
+#### `system/info`
+- **Location**: `src/cli/utils/advanced-interactive-ui.ts` (line ~2565)
+- **Formatting**:
+  - Shows text content directly
+  - Example: `Stream closed (complete)`
+
+#### `system/welcome`
+- **Location**: `src/cli/utils/advanced-interactive-ui.ts` (line ~2569)
+- **Formatting**:
+  - Shows your participant ID, capability count, and other participants
+  - Example: `connected as participant-123 (2 capabilities) • 2 other participants: mew, mcp-fs-bridge`
+  - Concise format to avoid bloat (per spec recommendation)
+
 ### 🛠️ Tool-Specific Formatters
 
 The advanced UI includes a pluggable tool formatter system for `mcp/proposal` messages:
@@ -77,11 +118,10 @@ The advanced UI includes a pluggable tool formatter system for `mcp/proposal` me
 
 These message types fall back to generic JSON preview in `getPayloadPreview()`:
 
-#### `system/*` (except `help`)
-- `system/welcome`
+#### `system/*` (except `help`, `info`, `welcome`)
 - `system/heartbeat`
 - `system/error`
-- `system/info`
+- `system/presence`
 - **Current behavior**: Generic object preview showing first 2-3 keys
 
 #### `participant/*`
@@ -97,19 +137,15 @@ These message types fall back to generic JSON preview in `getPayloadPreview()`:
 - `participant/compact-done`
 - **Current behavior**: Generic object preview
 
-#### `stream/*`
-- `stream/open`
-- `stream/close`
-- `stream/request`
-- `stream/data`
-- **Current behavior**: Generic object preview (though `stream/data` is filtered from display)
+#### `stream/data`
+- **Current behavior**: Filtered from display (binary/chunked data, not shown in envelope view)
 
 #### `capability/*`
 - `capability/grant`
 - `capability/grant-ack`
 - **Current behavior**: Generic object preview
 
-#### `chat/acknowledge` & `chat/cancel`
+#### `chat/cancel`
 - **Current behavior**: Generic object preview
 
 #### Other Protocol Messages
@@ -118,29 +154,25 @@ These message types fall back to generic JSON preview in `getPayloadPreview()`:
 
 ## Formatter Architecture
 
-### Interactive UI (Simple)
-- **File**: `src/cli/utils/interactive-ui.ts`
-- **Function**: `getPayloadPreview()` (line ~700)
-- **Approach**: Switch statement with kind-specific logic
-
-### Advanced UI (Rich)
+### Advanced UI (Only)
 - **File**: `src/cli/utils/advanced-interactive-ui.ts`
+- **Function**: `getPayloadPreview()` (line ~2540)
 - **Component**: `ReasoningDisplay` (line ~1880)
 - **Approach**: React component with pluggable tool formatters
 - **Tool Formatters**: Object registry at line ~1300
+- **Note**: The simple readline UI has been removed as of v0.5
 
 ## Recommendations
 
 ### High Priority Formatters
 1. **`system/error`** - Errors should have distinct formatting (red, prominent)
 2. **`participant/status`** - Status telemetry could be tabular
-3. **`stream/open`** - Stream info could show direction/encoding
-4. **`capability/grant`** - Security-critical, needs clear display
+3. **`capability/grant`** - Security-critical, needs clear display
 
 ### Medium Priority Formatters
-1. **`system/welcome`** - Connection info could be structured
-2. **`participant/pause`** - Show timeout and reason clearly
-3. **`chat/acknowledge`** - Show ack status visually
+1. **`participant/pause`** - Show timeout and reason clearly
+2. **`chat/cancel`** - Show cancellation status visually
+3. **`system/presence`** - Show join/leave events clearly
 
 ### Tool Formatters to Add
 1. **`read_file`** - Show file path and size

src/cli/commands/space.ts

@@ -17,7 +17,6 @@ import {
   getInteractiveOverrides,
 } from '../utils/participant-resolver.js';
 import { printBanner } from '../utils/banner.js';
-import * as interactiveUI from '../utils/interactive-ui.js';
 import * as advancedInteractiveUI from '../utils/advanced-interactive-ui.js';
 import { getTheme } from '../themes.js';
 
@@ -894,15 +893,6 @@ async function spaceUpAction(options) {
     if (options.interactive) {
       console.log('\nConnecting interactively...\n');
 
-      // Determine UI mode
-      const useDebugUI = options.debug || options.simple || options.noUi;
-
-      // Select appropriate UI module
-      const InteractiveUI = useDebugUI ? interactiveUI : null;
-      const startAdvancedInteractiveUI = useDebugUI
-        ? null
-        : advancedInteractiveUI.startAdvancedInteractiveUI;
-
       try {
         // Resolve participant
         const participant = await resolveParticipant({
@@ -944,41 +934,27 @@ async function spaceUpAction(options) {
           const theme = getTheme(themeName);
 
           // Display banner before starting UI
-          if (!useDebugUI) {
-            printBanner({
-              spaceName: spaceName,
-              spaceId: spaceId,
-              participantId: participant.id,
-              gateway: `ws://localhost:${selectedPort}`,
-              color: process.env.NO_COLOR !== '1',
-              theme: theme
-            });
-          }
+          printBanner({
+            spaceName: spaceName,
+            spaceId: spaceId,
+            participantId: participant.id,
+            gateway: `ws://localhost:${selectedPort}`,
+            color: process.env.NO_COLOR !== '1',
+            theme: theme
+          });
 
-          // Start interactive UI
-          if (useDebugUI) {
-            const defaultChatTargets = {
-              participant: Array.isArray(config?.participants?.[participant.id]?.default_to?.chat)
-                ? config.participants[participant.id].default_to.chat.slice()
-                : null,
-              global: Array.isArray(config?.defaults?.routing?.default_to?.chat)
-                ? config.defaults.routing.default_to.chat.slice()
-                : null
-            };
-            const ui = new InteractiveUI(ws, participant.id, spaceId, defaultChatTargets);
-            ui.start();
-          } else {
-            // Compute default chat targets from config
-            const defaultChatTargets = {
-              participant: Array.isArray(config?.participants?.[participant.id]?.default_to?.chat)
-                ? config.participants[participant.id].default_to.chat.slice()
-                : null,
-              global: Array.isArray(config?.defaults?.routing?.default_to?.chat)
-                ? config.defaults.routing.default_to.chat.slice()
-                : null
-            };
-            startAdvancedInteractiveUI(ws, participant.id, spaceId, themeName, defaultChatTargets);
-          }
+          // Compute default chat targets from config
+          const defaultChatTargets = {
+            participant: Array.isArray(config?.participants?.[participant.id]?.default_to?.chat)
+              ? config.participants[participant.id].default_to.chat.slice()
+              : null,
+            global: Array.isArray(config?.defaults?.routing?.default_to?.chat)
+              ? config.defaults.routing.default_to.chat.slice()
+              : null
+          };
+
+          // Start advanced interactive UI
+          advancedInteractiveUI.startAdvancedInteractiveUI(ws, participant.id, spaceId, themeName, defaultChatTargets);
         });
 
         ws.on('error', (err) => {
@@ -1003,9 +979,6 @@ space
   .option('-i, --interactive', 'Connect interactively after starting space')
   .option('--detach', 'Run in background (default if not interactive)')
   .option('--participant <id>', 'Connect as this participant (with --interactive)')
-  .option('--debug', 'Use simple debug interface instead of advanced UI')
-  .option('--simple', 'Alias for --debug')
-  .option('--no-ui', 'Disable UI enhancements, use plain interface')
   .action(spaceUpAction);
 
 // Action handler for space down
@@ -1539,9 +1512,6 @@ space
   .option('-d, --space-dir <path>', 'Directory of space to connect to', '.')
   .option('--participant <id>', 'Connect as this participant')
   .option('--gateway <url>', 'Override gateway URL (default: from running space)')
-  .option('--debug', 'Use simple debug interface instead of advanced UI')
-  .option('--simple', 'Alias for --debug')
-  .option('--no-ui', 'Disable UI enhancements, use plain interface')
   .action(async (options) => {
     const spaceDir = path.resolve(options.spaceDir);
     const configPath = path.join(spaceDir, path.basename(options.config));
@@ -1563,15 +1533,6 @@ space
     console.log(`Space: ${pids.spaceName} (${spaceId})`);
     console.log(`Gateway: ${gatewayUrl}`);
 
-    // Determine UI mode
-    const useDebugUI = options.debug || options.simple || options.noUi;
-
-    // Select appropriate UI module
-    const InteractiveUI = useDebugUI ? interactiveUI : null;
-    const startAdvancedInteractiveUI = useDebugUI
-      ? null
-      : advancedInteractiveUI.startAdvancedInteractiveUI;
-
     try {
       // Resolve participant
       const participant = await resolveParticipant({
@@ -1613,33 +1574,27 @@ space
         const theme = getTheme(themeName);
 
         // Display banner before starting UI
-        if (!useDebugUI) {
-          printBanner({
-            spaceName: pids.spaceName,
-            spaceId: spaceId,
-            participantId: participant.id,
-            gateway: gatewayUrl,
-            color: process.env.NO_COLOR !== '1',
-            theme: theme
-          });
-        }
+        printBanner({
+          spaceName: pids.spaceName,
+          spaceId: spaceId,
+          participantId: participant.id,
+          gateway: gatewayUrl,
+          color: process.env.NO_COLOR !== '1',
+          theme: theme
+        });
 
-        // Start interactive UI
-        if (useDebugUI) {
-          const ui = new InteractiveUI(ws, participant.id, spaceId);
-          ui.start();
-        } else {
-          // Compute default chat targets from config
-          const defaultChatTargets = {
-            participant: Array.isArray(config?.participants?.[participant.id]?.default_to?.chat)
-              ? config.participants[participant.id].default_to.chat.slice()
-              : null,
-            global: Array.isArray(config?.defaults?.routing?.default_to?.chat)
-              ? config.defaults.routing.default_to.chat.slice()
-              : null
-          };
-          startAdvancedInteractiveUI(ws, participant.id, spaceId, themeName, defaultChatTargets);
-        }
+        // Compute default chat targets from config
+        const defaultChatTargets = {
+          participant: Array.isArray(config?.participants?.[participant.id]?.default_to?.chat)
+            ? config.participants[participant.id].default_to.chat.slice()
+            : null,
+          global: Array.isArray(config?.defaults?.routing?.default_to?.chat)
+            ? config.defaults.routing.default_to.chat.slice()
+            : null
+        };
+
+        // Start advanced interactive UI
+        advancedInteractiveUI.startAdvancedInteractiveUI(ws, participant.id, spaceId, themeName, defaultChatTargets);
       });
 
       ws.on('error', (err) => {

src/cli/ui/components/EnhancedInput.ts

@@ -17,17 +17,7 @@ import { useKeypress } from '../hooks/useKeypress.js';
 import { getCommand } from '../keyMatchers.js';
 import { defaultKeyBindings } from '../../config/keyBindings.js';
 import { getSlashCommandSuggestions } from '../utils/slashCommands.js';
-import fs from 'fs';
-import path from 'path';
-// Helper function for debug logging
-const debugLog = (message) => {
-  const logFile = path.join(process.cwd(), '.mew', 'debug.log');
-  const mewDir = path.join(process.cwd(), '.mew');
-  if (!fs.existsSync(mewDir)) {
-    fs.mkdirSync(mewDir, { recursive: true });
-  }
-  fs.appendFileSync(logFile, message);
-};
+import { debugLog } from '../../utils/debug.js';
 
 /**
  * Enhanced Input Component
@@ -44,12 +34,12 @@ const debugLog = (message) => {
  * @returns {React.Element}
  */
 function EnhancedInput({
-  onSubmit = () => {},
+  onSubmit = () => { },
   placeholder = '',
   multiline = false,
   disabled = false,
   history = [],
-  onHistoryChange = () => {},
+  onHistoryChange = () => { },
   keyBindings = defaultKeyBindings,
   showCursor = true,
   prompt = '> ',
@@ -326,7 +316,7 @@ function EnhancedInput({
 
       // Submission
       case 'SUBMIT':
-        debugLog(`\n>>> SUBMIT CASE REACHED <<<\n`);
+        debugLog(`\n>>> SUBMIT CASE REACHED 2 <<<\n`);
         debugLog(`>>> Buffer text: "${buffer.getText()}"\n`);
         if (!multiline || !buffer.getText().includes('\n')) {
           debugLog(`>>> CALLING handleSubmit() <<<\n`);