Merge pull request #110 from rmrk-team/feat/collection-count-validation

update count field on collection when nft is minted or burned to vali…

Author: Yuripetusko

src/rmrk2.0.0/classes/collection.ts

@@ -13,6 +13,7 @@ export class Collection {
   readonly id: string;
   readonly metadata: string;
   changes: Change[] = [];
+  count = 0;
 
   constructor(
     block: number,

src/rmrk2.0.0/tools/consolidator/adapters/in-memory-adapter.ts

@@ -171,6 +171,9 @@ export class InMemoryAdapter implements IConsolidatorAdapter {
       equipped: "",
       forsale: BigInt(nft.forsale) > BigInt(0) ? BigInt(0) : nft.forsale,
     };
+
+    this.collections[consolidatedNFT.collection].count =
+      this.collections[consolidatedNFT.collection].count - 1;
   }
 
   public async updateNFTMint(nft: NFT) {
@@ -179,6 +182,8 @@ export class InMemoryAdapter implements IConsolidatorAdapter {
       symbol: nft.symbol,
       id: nft.getId(),
     };
+    this.collections[nft.collection].count =
+      this.collections[nft.collection].count + 1;
   }
 
   public async updateCollectionMint(collection: CollectionConsolidated) {

src/rmrk2.0.0/tools/consolidator/consolidator.ts

@@ -106,6 +106,7 @@ export interface CollectionConsolidated {
   id: string;
   metadata: string;
   changes: Change[];
+  count: number;
 }
 
 export interface BaseConsolidated {

src/rmrk2.0.0/tools/consolidator/interactions/burn.ts

@@ -5,7 +5,10 @@ import { Remark } from "../remark";
 import { Burn } from "../../../classes/burn";
 import { NFT } from "../../../classes/nft";
 import { hexToString } from "@polkadot/util";
-import { isValidAddressPolkadotAddress } from "../utils";
+import {
+  consolidatedCollectionToInstance,
+  isValidAddressPolkadotAddress,
+} from "../utils";
 import { IConsolidatorAdapter } from "../adapters/types";
 import { NFTConsolidated } from "../consolidator";
 

src/rmrk2.0.0/tools/consolidator/interactions/mint.ts

@@ -23,10 +23,11 @@ export const validateMintNFT = async (
       `Attempted issue of NFT in non-owned collection. Issuer: ${nftParentCollection.issuer}, caller: ${remark.caller}`
     );
   }
-  
-  const nfts = await dbAdapter.getNFTsByCollection(nftParentCollection.id);
-  const unburnedNfts = nfts ? nfts.filter((nft) => nft.burned === "") : [];
-  if (nftParentCollection.max <= unburnedNfts.length && nftParentCollection.max !== 0) {
+
+  if (
+    nftParentCollection.count >= nftParentCollection.max &&
+    nftParentCollection.max !== 0
+  ) {
     throw new Error(
       `Attempted to mint into maxed out collection ${nftParentCollection.id}`
     );

src/rmrk2.0.0/tools/consolidator/utils.ts

@@ -189,9 +189,10 @@ export const consolidatedCollectionToInstance = (
     id,
     metadata
   );
-  const { changes } = rest;
+  const { changes, count } = rest;
 
   collectionInstance.changes = changes;
+  collectionInstance.count = count;
   return collectionInstance;
 };