chore: remove duplicate test, simplify comments

Author: lykimq

tests/auto_detection_test.ml

@@ -2,17 +2,9 @@ open Test_helpers
 open Auto_detection
 open Alcotest
 
-(** Test GitLab info detection - should fallback to default domain if not found
-  *)
 let test_auto_detect_gitlab_info () =
   (* Test with real GitLab API if credentials are available, otherwise use mock *)
-  let bot_info =
-    match create_real_bot_info () with
-    | Some info ->
-        info (* Use real credentials if available *)
-    | None ->
-        create_mock_bot_info () (* Fallback to mock *)
-  in
+  let bot_info = get_bot_info () in
   let owner = "test-org" in
   let repo = "test-repo" in
   let result =
@@ -30,12 +22,12 @@ let test_auto_detect_gitlab_info () =
 
 (** Test org/team detection with real API or graceful skip *)
 let test_auto_detect_org_team () =
-  (* Test with real GitHub API if credentials are available *)
-  match create_real_bot_info () with
+  let bot_info = get_bot_info () in
+  (* Skip test if no real credentials - this is expected in CI without secrets *)
+  match bot_info.github_install_token with
   | None ->
-      (* Skip test if no credentials - this is expected in CI without secrets *)
       Alcotest.skip ()
-  | Some bot_info -> (
+  | Some _ -> (
       (* Use a real public repository for testing that is known to exist *)
       let owner = "ocaml" in
       let repo = "opam" in
@@ -63,12 +55,12 @@ let test_auto_detect_org_team () =
 
 (** Test complete auto-detection with caching *)
 let test_auto_detect_from_apis () =
-  (* Test with real GitHub API if credentials are available *)
-  match create_real_bot_info () with
+  let bot_info = get_bot_info () in
+  (* Skip test if no real credentials *)
+  match bot_info.github_install_token with
   | None ->
-      (* Skip test if no credentials - this is expected in CI without secrets *)
       Alcotest.skip ()
-  | Some bot_info ->
+  | Some _ ->
       (* Use a real public repository for testing *)
       let owner = "ocaml" in
       let repo = "opam" in
@@ -102,10 +94,12 @@ let test_auto_detect_from_apis () =
 
 (** Test that auto_detect_from_apis returns a complete Repo_config.t *)
 let test_auto_detect_from_apis_completeness () =
-  match create_real_bot_info () with
+  let bot_info = get_bot_info () in
+  (* Skip test if no real credentials *)
+  match bot_info.github_install_token with
   | None ->
       Alcotest.skip ()
-  | Some bot_info ->
+  | Some _ ->
       let owner = "ocaml" in
       let repo = "opam" in
       Cache.clear_all () ;
@@ -124,8 +118,6 @@ let test_auto_detect_from_apis_completeness () =
       check bool "org_name is Some" (Option.is_some result.org_name) true ;
       (* team_name should be Some *)
       check bool "team_name is Some" (Option.is_some result.team_name) true ;
-      (* minimizer_url may be Some (if BOT_MINIMIZER_URL env var is set) or None (generic default) *)
-      (* This is acceptable - minimizer_url is optional and can be configured per-repo *)
       (* ci_config should be Some (from defaults) *)
       check bool "ci_config is Some" (Option.is_some result.ci_config) true
 

tests/config_resolver_test.ml

@@ -2,12 +2,7 @@ open Repo_config
 open Alcotest
 open Test_helpers
 
-let bot_info =
-  match create_real_bot_info () with
-  | Some info ->
-      info
-  | None ->
-      create_mock_bot_info ()
+let bot_info = get_bot_info ()
 
 let test_merge_priority_explicit_overrides () =
   let explicit_config =
@@ -70,7 +65,6 @@ let test_merge_priority_api_fills_gaps () =
   check (option string) "api team_name" result.team_name (Some "maintainers")
 
 let test_merge_priority_defaults_fallback () =
-  (* Skip test if no real credentials - API calls require installation token *)
   ( match bot_info.github_install_token with
   | None ->
       Alcotest.skip ()

tests/default_config_test.ml

@@ -48,5 +48,5 @@ let () =
     [ ( "defaults"
       , [test_case "defaults for any repo" `Quick test_defaults_for_any_repo] )
     ; ( "no_hardcoded_patterns"
-      , [ test_case "defaults for any repo" `Quick
+      , [ test_case "no hardcoded patterns" `Quick
             test_defaults_no_hardcoded_patterns ] ) ]

tests/dune

@@ -50,76 +50,15 @@
  (libraries base bot-components config alcotest lwt lwt.unix)
  (modules test_helpers config_resolver_test))
 
-(test
- (name refactored_code_test_helpers)
- (libraries base bot-components config utils)
- (modules refactored_code_test_helpers))
-
-(test
- (name refactored_code_generic_test)
- (libraries base bot-components config alcotest utils)
- (modules
-  test_helpers
-  refactored_code_test_helpers
-  refactored_code_generic_test))
-
-(test
- (name refactored_code_backport_test)
- (libraries base bot-components config alcotest)
- (modules
-  test_helpers
-  refactored_code_test_helpers
-  refactored_code_backport_test))
-
-(test
- (name refactored_code_jobs_test)
- (libraries base bot-components config alcotest)
- (modules
-  test_helpers
-  refactored_code_test_helpers
-  refactored_code_jobs_test))
-
-(test
- (name refactored_code_ci_test)
- (libraries base bot-components config alcotest)
- (modules test_helpers refactored_code_test_helpers refactored_code_ci_test))
-
-(test
- (name refactored_code_documentation_test)
- (libraries base bot-components config alcotest)
- (modules
-  test_helpers
-  refactored_code_test_helpers
-  refactored_code_documentation_test))
-
-(test
- (name refactored_code_gitlab_test)
- (libraries base bot-components config alcotest)
- (modules
-  test_helpers
-  refactored_code_test_helpers
-  refactored_code_gitlab_test))
-
-(test
- (name refactored_code_bench_test)
- (libraries base bot-components config alcotest)
- (modules
-  test_helpers
-  refactored_code_test_helpers
-  refactored_code_bench_test))
-
 (test
  (name refactored_code_edge_cases_test)
  (libraries base bot-components config alcotest utils)
- (modules
-  test_helpers
-  refactored_code_test_helpers
-  refactored_code_edge_cases_test))
+ (modules test_helpers refactored_code_edge_cases_test))
 
 (test
  (name job_status_custom_test)
  (libraries base bot-components config alcotest ci lwt lwt.unix)
- (modules test_helpers refactored_code_test_helpers job_status_custom_test))
+ (modules test_helpers job_status_custom_test))
 
 (test
  (name generic_bot_demo_test)