Remove legacy boundary module from physics

Author: rafa-guedes

src/rompy_xbeach/components/physics/physics.py

@@ -5,7 +5,6 @@
 
 from pydantic import Field, model_validator
 
-from rompy_xbeach.components.physics.wbc import WaveBoundaryConditions
 from rompy_xbeach.components.physics.constants import Coriolis, PhysicalConstants
 from rompy_xbeach.components.physics.wci import (
     WaveCurrentInteraction,
@@ -174,12 +173,6 @@ class Physics(XBeachBaseModel):
         default=None,
         description="Wave numerical parameters (scheme, maxiter, maxerror, wavint)",
     )
-    wave_boundary: Optional[WaveBoundaryConditions] = Field(
-        default=None,
-        description=(
-            "Wave boundary condition parameters (nmax, wbcevarreduce, bclwonly, etc.)"
-        ),
-    )
     nonhydrostatic_numerics: Optional[NonHydrostaticNumerics] = Field(
         default=None,
         description=(
@@ -246,6 +239,7 @@ def log_default_enabled_processes(self) -> "Physics":
             "avalanching",
             "flow",
             "lwave",
+            # "sedtrans",
             "single_dir",
             "swave",
             "viscosity",

src/rompy_xbeach/components/physics/wbc.py

@@ -95,14 +95,6 @@ physics:
     cats: 4.0
     hwci: 0.1
     hwcimax: 100.0
-  wave_boundary:
-    nmax: 0.8
-    wbcevarreduce: 1.0
-    bclwonly: False
-    swkhmin: -0.01
-    wbcRemoveStokes: 1
-    wbcScaleEnergy: 1
-    cyclicdiradjust: 0
   wave_numerics:
     scheme: warmbeam
     maxiter: 500

tests/test_config.yml

@@ -2,7 +2,6 @@
 
 import pytest
 from rompy_xbeach.components.physics import Physics
-from rompy_xbeach.components.physics.wbc import WaveBoundaryConditions
 from rompy_xbeach.components.physics.constants import Coriolis, PhysicalConstants
 from rompy_xbeach.components.physics.friction import HorizontalViscosity
 from rompy_xbeach.components.physics.wci import WaveCurrentInteraction
@@ -79,27 +78,6 @@ def test_wave_numerics():
     assert params["wavint"] == 300.0
 
 
-def test_wave_boundary_conditions():
-    """Test WaveBoundaryConditions model."""
-    wave_bc = WaveBoundaryConditions(
-        nmax=0.7,
-        wbcevarreduce=0.8,
-        bclwonly=True,
-        swkhmin=0.01,
-        wbcRemoveStokes=False,
-        wbcScaleEnergy=True,
-        cyclicdiradjust=False,
-    )
-    params = wave_bc.params
-    assert params["nmax"] == 0.7
-    assert params["wbcevarreduce"] == 0.8
-    assert params["bclwonly"] == 1
-    assert params["swkhmin"] == 0.01
-    assert params["wbcRemoveStokes"] == 0
-    assert params["wbcScaleEnergy"] == 1
-    assert params["cyclicdiradjust"] == 0
-
-
 def test_nonhydrostatic_numerics():
     """Test NonHydrostaticNumerics model."""
     nh_num = NonHydrostaticNumerics(
@@ -180,10 +158,6 @@ def test_physics_with_all_new_components():
             maxiter=500,
             maxerror=0.0005,
         ),
-        wave_boundary=WaveBoundaryConditions(
-            nmax=0.8,
-            wbcScaleEnergy=True,
-        ),
         constants=PhysicalConstants(
             g=9.81,
             rho=1025.0,
@@ -218,10 +192,6 @@ def test_physics_with_all_new_components():
     assert params["maxiter"] == 500
     assert params["maxerror"] == 0.0005
 
-    # Check wave boundary
-    assert params["nmax"] == 0.8
-    assert params["wbcScaleEnergy"] == 1
-
     # Check constants
     assert params["g"] == 9.81
     assert params["rho"] == 1025.0