feat(permission groups): added automatic assigning of is_staff flag #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikjelle
force-pushed
the
feature/pgroup_is_staff_assignment
branch
from
59dc950 to
9435b23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rewrote the part that set the is_staff flag when assigning a person to and from a localgroup.contact_person.
It now sets a contact person permission group instead
And then it just will loop through all permissions groups and if the GroupFlags.members_become_staff is True, we set the is_staff flag.
I am also assuming GroupFlags.members_become_staff was not working before, so it has a function now. (correct me if I am wrong)