Skip to content

[Ruby 3.4] Add test for deprecation warning for Symbol#to_s #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Ruby 3.4] Add test for deprecation warning for Symbol#to_s #1294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions core/symbol/shared/id2name.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,18 @@

symbol.send(@method).encoding.should == Encoding::US_ASCII
end

ruby_version_is "3.4" do
it "warns about mutating returned string" do
-> { :bad!.send(@method).upcase! }.should complain(/warning: string returned by :bad!.to_s will be frozen in the future/)
end

it "does not warn about mutation when Warning[:deprecated] is false" do
deprecated = Warning[:deprecated]
Warning[:deprecated] = false
-> { :bad!.send(@method).upcase! }.should_not complain
ensure
Warning[:deprecated] = deprecated
end
end
end