"started" requests that should be "fulfilled"

[cielf]

Summary

Fix problem where it's possible to make an already fulfilled request "started"

Details

If you view an unstarted request from two different windows (whether or not on the same machine), click fulfil, and save the distribution on the first one, then click 'fulfill' on the second, the request is changed to "started" -- it doesn't check that it's already fulfilled.

In this case, we should give an error indicating that the request has already been fulfilled, and not change the status.

This should be handled at the model level -- if something is fulfilled, you should not be able to change it.

See

human-essentials/app/controllers/requests_controller.rb

Line 40 in 83508dc

request.status_started!

Also provide a migration to clean up any requests that have a scheduled or completed distribution associated with them and are "started".

Criteria for completion

• behaviour as described
• automated tests to confirm behaviour
• migration to clean up requests with this issue (this already exists, but will need to be invoked again)
• No user guide changes needed

[GreenGogh47]

Could I try this one?

[cielf]

Please do

[GreenGogh47]

I've submitted a PR. Let me know what changes I need to make when you can.

[github-actions]

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

[github-actions]

Automatically unassigned after 7 days of inactivity.