fix(clean): Clean up incremental builds with new layout

Author: epage

src/cargo/ops/cargo_clean.rs

@@ -209,6 +209,7 @@ fn clean_specs(
                 if target.is_custom_build() {
                     continue;
                 }
+                let crate_name: Rc<str> = target.crate_name().into();
                 for &mode in &[
                     CompileMode::Build,
                     CompileMode::Test,
@@ -240,6 +241,10 @@ fn clean_specs(
                                 clean_ctx.rm_rf(&dep_info)?;
                             }
                         }
+
+                        let dir = escape_glob_path(layout.build_dir().incremental())?;
+                        let incremental = Path::new(&dir).join(format!("{}-*", crate_name));
+                        clean_ctx.rm_rf_glob(&incremental)?;
                     }
                 }
             }

tests/testsuite/clean_new_layout.rs

@@ -142,6 +142,10 @@ fn clean_multiple_packages_in_glob_char_path() {
     p.cargo("clean -p foo")
         .arg("-Zbuild-dir-new-layout")
         .masquerade_as_nightly_cargo(&["new build-dir layout"])
+        .with_stderr_data(str![[r#"
+[REMOVED] [FILE_NUM] files, [FILE_SIZE]B total
+
+"#]])
         .run();
     assert_eq!(get_build_artifacts(foo_path, file_glob).len(), 0);
 }
@@ -598,7 +602,7 @@ fn package_cleans_all_the_things() {
             .arg("-Zbuild-dir-new-layout")
             .masquerade_as_nightly_cargo(&["new build-dir layout"])
             .run();
-        //assert_all_clean(&p.build_dir());  // FIXME
+        assert_all_clean(&p.build_dir());
     }
     let p = project()
         .file(
@@ -657,7 +661,7 @@ fn package_cleans_all_the_things() {
         .arg("-Zbuild-dir-new-layout")
         .masquerade_as_nightly_cargo(&["new build-dir layout"])
         .run();
-    //assert_all_clean(&p.build_dir());  // FIXME
+    assert_all_clean(&p.build_dir());
 
     // Try some targets.
     p.cargo("build --all-targets --target")
@@ -670,7 +674,43 @@ fn package_cleans_all_the_things() {
         .arg("-Zbuild-dir-new-layout")
         .masquerade_as_nightly_cargo(&["new build-dir layout"])
         .run();
-    //assert_all_clean(&p.build_dir());  // FIXME
+    assert_all_clean(&p.build_dir());
+}
+
+// Ensures that all files for the package have been deleted.
+#[track_caller]
+fn assert_all_clean(build_dir: &Path) {
+    let walker = walkdir::WalkDir::new(build_dir).into_iter();
+    for entry in walker.filter_entry(|e| {
+        let path = e.path();
+        // This is a known limitation, clean can't differentiate between
+        // the different build scripts from different packages.
+        !(path
+            .file_name()
+            .unwrap()
+            .to_str()
+            .unwrap()
+            .starts_with("build_script_build")
+            && path
+                .parent()
+                .unwrap()
+                .file_name()
+                .unwrap()
+                .to_str()
+                .unwrap()
+                == "incremental")
+    }) {
+        let entry = entry.unwrap();
+        let path = entry.path();
+        if let ".rustc_info.json" | ".cargo-lock" | "CACHEDIR.TAG" =
+            path.file_name().unwrap().to_str().unwrap()
+        {
+            continue;
+        }
+        if path.is_symlink() || path.is_file() {
+            panic!("{:?} was not cleaned", path);
+        }
+    }
 }
 
 #[cargo_test]