-
Notifications
You must be signed in to change notification settings - Fork 442
fix props #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughConfiguration allows "WebSearch" in .claude/settings.local.json. In pageviewQueue.ts, removed JSON parsing of pv.properties; now passes raw string or null as props. No other flow changes. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Src as Tracker Source
participant Q as PageviewQueue
participant Down as Downstream Consumer
Src->>Q: enqueue(pageview with pv.properties)
rect rgba(200,220,255,0.25)
note over Q: Changed: props assignment
Q->>Q: props = pv.properties || null
note over Q: Previously: props = JSON.parse(pv.properties)? else undefined
end
Q-->>Down: pageview { props: string|null, ... }
Down->>Down: Handle props as string/null (no parsed object)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (2)
🧰 Additional context used📓 Path-based instructions (2){client,server}/**/*.{ts,tsx}📄 CodeRabbit inference engine (CLAUDE.md)
Files:
server/**/*📄 CodeRabbit inference engine (CLAUDE.md)
Files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (2)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary by CodeRabbit
New Features
Refactor
Chores