sanitise result #18
sanitise result #18
Conversation
|
|
||
| public func sanitizeResult() { | ||
| self.result = self.result | ||
| .replacingOccurrences(of: "simd_float2,", with: "SIMD2<Float>,") |
There was a problem hiding this comment.
why include commas and brackets into replacement?
There was a problem hiding this comment.
to ignore float2x2, float3x3 etc.
There was a problem hiding this comment.
the pr looks hacky, but does the job
| var swiftTypeName = scanner.leftString | ||
| .trimmingCharacters(in: .whitespacesAndNewlines) | ||
| if #available(OSX 10.12, *), | ||
| let checkedType = TypeSanitizer.sanitizeType(swiftTypeName) { |
There was a problem hiding this comment.
I think we can have it, at least as an experimental feature, but we defintely need to introduce a command line argument parameter for this
also, you have to keep in mind that users can use aliases/typenames of their private codebase and that is totally fine (we do not limit swift type usage to simd) hence your approach won't work for such types. I see that we check for nil here but still. I think what we can do instead is introduce a simple dictionary here and try map swiftTypeName to something else
No description provided.