Reschedule mail delivery if change to event is significant

Jonas Heinrich · Jonas Heinrich · commit 81ebab037242 · 2023-01-24T18:04:55.000+01:00
diff --git a/lib/CalDAV/Schedule/Plugin.php b/lib/CalDAV/Schedule/Plugin.php
@@ -638,7 +638,13 @@ protected function processICalendarChange($oldObject, VCalendar $newObject, arra
                             if ($message->scheduleStatus) {
                                 $attendee['SCHEDULE-STATUS'] = $message->getScheduleStatus();
                             }
-                            unset($attendee['SCHEDULE-FORCE-SEND']);
+                            
+                            // Only ignore rescheduling if change is not significant,
+                            // unsetting SCHEDULE-FORCE-SEND. Respecting RFC 6638 3.2.8.
+                            if (!$message->significantChange) {
+                                unset($attendee['SCHEDULE-FORCE-SEND']);
+                            };
+
                             break;
                         }
                     }

Original file line number	Diff line number	Diff line change
`@@ -638,7 +638,13 @@ protected function processICalendarChange($oldObject, VCalendar $newObject, arra`
`638`	`638`	`if ($message->scheduleStatus) {`
`639`	`639`	`$attendee['SCHEDULE-STATUS'] = $message->getScheduleStatus();`
`640`	`640`	`}`
`641`		`- unset($attendee['SCHEDULE-FORCE-SEND']);`
	`641`	`+`
	`642`	`+ // Only ignore rescheduling if change is not significant,`
	`643`	`+ // unsetting SCHEDULE-FORCE-SEND. Respecting RFC 6638 3.2.8.`
	`644`	`+ if (!$message->significantChange) {`
	`645`	`+ unset($attendee['SCHEDULE-FORCE-SEND']);`
	`646`	`+ };`
	`647`	`+`
`642`	`648`	`break;`
`643`	`649`	`}`
`644`	`650`	`}`