Testing coverage back at 100%

Author: evert

tests/Sabre/XML/Element/Eater.php

@@ -0,0 +1,78 @@
+<?php
+
+namespace Sabre\XML\Element;
+
+use Sabre\XML;
+
+/**
+ * The intention for this reader class, is to read past the end element. This
+ * should trigger a ParseException
+ *
+ * @copyright Copyright (C) 2007-2013 Rooftop Solutions. All rights reserved.
+ * @author Evert Pot (http://www.rooftopsolutions.nl/)
+ * @license http://code.google.com/p/sabredav/wiki/License Modified BSD License
+ */
+class Eater implements XML\Element {
+
+    /**
+     * The serialize method is called during xml writing.
+     *
+     * It should use the $writer argument to encode this object into XML.
+     *
+     * Important note: it is not needed to create the parent element. The
+     * parent element is already created, and we only have to worry about
+     * attributes, child elements and text (if any).
+     *
+     * Important note 2: If you are writing any new elements, you are also
+     * responsible for closing them.
+     *
+     * @param XML\Writer $writer
+     * @return void
+     */
+    public function serializeXml(XML\Writer $writer) {
+
+        $writer->startElement('{http://sabredav.org/ns}elem1');
+        $writer->write('hiiii!');
+        $writer->endElement();
+
+    }
+
+    /**
+     * The deserialize method is called during xml parsing.
+     *
+     * This method is called statictly, this is because in theory this method
+     * may be used as a type of constructor, or factory method.
+     *
+     * Often you want to return an instance of the current class, but you are
+     * free to return other data as well.
+     *
+     * Important note 2: You are responsible for advancing the reader to the
+     * next element. Not doing anything will result in a never-ending loop.
+     *
+     * If you just want to skip parsing for this element altogether, you can
+     * just call $reader->next();
+     *
+     * $reader->parseSubTree() will parse the entire sub-tree, and advance to
+     * the next element.
+     *
+     * @param XML\Reader $reader
+     * @return mixed
+     */
+    static public function deserializeXml(XML\Reader $reader) {
+
+        $reader->next();
+
+        $count = 1;
+        while($count) {
+
+            $reader->read();
+            if ($reader->nodeType === $reader::END_ELEMENT) {
+                $count--;
+            }
+
+        }
+        $reader->read();
+
+    }
+
+}

tests/Sabre/XML/ReaderTest.php

@@ -172,5 +172,27 @@ function testParseProblem() {
 
     }
 
+    /**
+     * @expectedException \Sabre\XML\ParseException
+     */
+    function testBrokenParserClass() {
+
+        $input = <<<BLA
+<?xml version="1.0"?>
+<root xmlns="http://sabredav.org/ns">
+<elem1 />
+</root>
+BLA;
+
+        $reader = new Reader();
+        $reader->elementMap = [
+            '{http://sabredav.org/ns}elem1' => 'Sabre\\XML\\Element\\Eater'
+        ];
+        $reader->xml($input);
+        $reader->parse();
+
+
+    }
+
 }
 

tests/bootstrap.php

@@ -5,3 +5,4 @@
 
 // Some extra classes
 include __DIR__ . '/Sabre/XML/Element/Mock.php';
+include __DIR__ . '/Sabre/XML/Element/Eater.php';