C++11 in-class initializer 対応 (CEditDoc) #2179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
berryzplus
approved these changes
Nov 29, 2025
| // 編集禁止コマンドの並びをチェック | ||
| int i; | ||
| for ( i = 0; i < _countof(EIsModificationForbidden) - 1; i++){ | ||
| for (auto i = 0; i < _countof(EIsModificationForbidden) - 1; i++){ |
Contributor
There was a problem hiding this comment.
指摘ではありません。
せっかく直すならこんな感じが好みです。
Suggested change
| for (auto i = 0; i < _countof(EIsModificationForbidden) - 1; i++){ | |
| for (size_t i = 0; i < std::size(EIsModificationForbidden); ++i) { |
（forループ終了条件の定義ミスをしれっと直そうとしてる点は、実害ないのでスルーして構いません。）
拡張 for に移行すると「より良い」はず。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR対象
カテゴリ
PR の背景
CEditDoc クラスで、メンバ変数をコンストラクタで初期化している。
仕様・動作説明
変数宣言時に初期化するようにします。
PR の影響範囲
影響なし。
テスト内容
変更前後で、 CEditDoc クラスのコンストラクタに break を設定し、メンバ変数を確認する。
関連 issue, PR
#2110
#2134
参考資料