Dependency problem using pip install -e .

[feiye-vims]

I tried to install pyschism in developer mode by

pip install -e .

in a new conda environment.

It runs for a long time and could not resolve the dependency:

error: resolution-too-deep

× Dependency resolution exceeded maximum depth
╰─> Pip cannot resolve the current dependencies as the dependency graph is too complex for pip to solve efficiently.

hint: Try adding lower bounds to constrain your dependencies, for example: 'package>=2.0.0' instead of just 'package'. 

I finally installed pyschism by manually installing dependencies using conda (#136), then tweaked the setup.py to remove the subprocess.check_call for installing dunamai (which caused other problems) and put dunamai into pyproject.toml, and eventually, pip install -e .

I wonder if this happened to others.

Also, a warning message said subprocess.check_call() inside setup.py is discouraged and will break builds starting in late 2025, so the setup.py probably needs to be updated soon.

[pmav99]

On a clean, non-conda virtual environment I had to do the following:

1. Remove all the subprocess.check_calls() in setup.py
2. Remove the dunamai import.
3. Hardcode the version
4. Comment out pygeos from the dependencies list because I was using python 3.12 and pygeos is not installable on recent python versions.

After these steps the editable install finished successfully:

$ python -mpip install -e ./pyschism 
[...]
Building wheels for collected packages: pyschism
  Building editable for pyschism (pyproject.toml) ... done
  Created wheel for pyschism: filename=pyschism-0.0.0-0.editable-py3-none-any.whl size=8814 sha256=6d2bc9abba064b3d37156f0d01fdf3fc4b6e3140d1a0fe1939cdd36508c25a9a
  Stored in directory: /tmp/panos/pip-ephem-wheel-cache-j0fmaaed/wheels/83/eb/d2/7b91d0465451c230a44b85c595a75e3de67c28df3e9d2d98d0
Successfully built pyschism
Installing collected packages: pyschism
  Attempting uninstall: pyschism
    Found existing installation: pyschism 0.0.0
    Uninstalling pyschism-0.0.0:
      Successfully uninstalled pyschism-0.0.0
Successfully installed pyschism-0.0.0

For the record, pygeos has been merged into shapely. AFAI can tell it is not being used in pyschism anymore. So it is probably safe to remove it.

Just for reference, this is the diff:

diff --git a/setup.py b/setup.py
index 9cd6ff9..7b568aa 100755
--- a/setup.py
+++ b/setup.py
@@ -4,28 +4,29 @@
 import subprocess
 import sys
 
-subprocess.check_call(
-    [sys.executable, '-m', 'pip', 'install', '--upgrade', 'pip'])
+#subprocess.check_call(
+#    [sys.executable, '-m', 'pip', 'install', '--upgrade', 'pip'])
+#
+#subprocess.check_call([sys.executable, '-m', 'pip', 'install', 'wheel'])
 
-subprocess.check_call([sys.executable, '-m', 'pip', 'install', 'wheel'])
-
-try:
-    from dunamai import Version
-except ImportError:
-    subprocess.check_call(
-            [sys.executable, '-m', 'pip', 'install', 'dunamai']
-    )
-    from dunamai import Version  # type: ignore[import]
-
-try:
-    version = Version.from_any_vcs().serialize()
-except RuntimeError:
-    version = '0.0.0'
-except ValueError as e:
-    if "time data '%cI' does not match format '%Y-%m-%dT%H:%M:%S%z'" in str(e):
-        version = '0.0.0'
-    else:
-        raise
+#try:
+#    from dunamai import Version
+#except ImportError:
+#    #subprocess.check_call(
+#    #        [sys.executable, '-m', 'pip', 'install', 'dunamai']
+#    #)
+#    from dunamai import Version  # type: ignore[import]
+#
+#try:
+#    version = Version.from_any_vcs().serialize()
+#except RuntimeError:
+#    version = '0.0.0'
+#except ValueError as e:
+#    if "time data '%cI' does not match format '%Y-%m-%dT%H:%M:%S%z'" in str(e):
+#        version = '0.0.0'
+#    else:
+#        raise
+version = '0.0.0'
 
 class BuildSchism(setuptools.Command):
 
@@ -115,7 +116,7 @@ def run(self):
         'numba',
         'ordered-set',
         'psutil',
-        'pygeos',
+        #'pygeos',
         'pyugrid',
         'rtree',
         'scipy',