Update cech.py

[OlympioH]

The build_thresh function takes a threshold parameter as input and build a proximity graph : an edge is in the proximity graph if the distance between two points is lower than the threshold value.It then checks for every simplex in the edges are in the proximity graph, and then computes the miniball of a simplex. The simplex is added iff the radius is lower than the given threshold. However it does not seem to accelerate the algorithm, maybe you can have some thoughts about it ? I know very little about CS and programming so there might be some stupid mistakes in the code, and call to functions unnecessarily costly.

[ctralie]

Hi, thanks for this! I will have a look as soon as I can. It depends on how this is written, but I wouldn't necessarily expect a speedup in the Delaunay triangulation, but instead I might expect a speedup in the filtration, since there will be fewer simplices. So if you choose a threshold such that many simplices are ignored, the filtration step (which is often the bottleneck) should be faster

…

On Mon, Oct 28, 2019 at 11:08 AM OlympioH ***@***.***> wrote: The build_thresh function takes a threshold parameter as input and build a proximity graph : an edge is in the proximity graph if the distance between two points is lower than the threshold value.It then checks for every simplex in the edges are in the proximity graph, and then computes the miniball of a simplex. The simplex is added iff the radius is lower than the given threshold. However it does not seem to accelerate the algorithm, maybe you can have some thoughts about it ? I know very little about CS and programming so there might be some stupid mistakes in the code, and call to functions unnecessarily costly. ------------------------------ You can view, comment on, or merge this pull request online at: #13 Commit Summary - Update cech.py File Changes - *M* cechmate/filtrations/cech.py <https://github.com/scikit-tda/cechmate/pull/13/files#diff-0> (77) Patch Links: - https://github.com/scikit-tda/cechmate/pull/13.patch - https://github.com/scikit-tda/cechmate/pull/13.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#13?email_source=notifications&email_token=AAJWDZWDJUZIPIWHIEGAB5DQQ3565A5CNFSM4JF3QZMKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HUZKVQQ>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJWDZR5XFBOHQMBSXVQNNTQQ3565ANCNFSM4JF3QZMA> .