[#621] UniquePersonList: Simplify logic of updatePerson(...) (#616)

This method retrieves the person in the list to be updated, and calls
Person#resetData(ReadOnlyPerson) to update the values of that person.

We do not need to retrieve the person in the list to be updated, to
update the list accordingly.

Let’s simplify the logic by setting the updated Person object in place
of the person to be updated.

Author: Zhiyuan-Amos

src/main/java/seedu/address/logic/commands/EditCommand.java

@@ -83,7 +83,7 @@ public CommandResult executeUndoableCommand() throws CommandException {
             throw new AssertionError("The target person cannot be missing");
         }
         model.updateFilteredListToShowAll();
-        return new CommandResult(String.format(MESSAGE_EDIT_PERSON_SUCCESS, personToEdit));
+        return new CommandResult(String.format(MESSAGE_EDIT_PERSON_SUCCESS, editedPerson));
     }
 
     /**

src/main/java/seedu/address/model/AddressBook.java

@@ -106,7 +106,7 @@ public void updatePerson(ReadOnlyPerson target, ReadOnlyPerson editedReadOnlyPer
         // TODO: the tags master list will be updated even though the below line fails.
         // This can cause the tags master list to have additional tags that are not tagged to any person
         // in the person list.
-        persons.updatePerson(target, editedPerson);
+        persons.setPerson(target, editedPerson);
     }
 
     /**

src/main/java/seedu/address/model/person/Person.java

@@ -122,19 +122,6 @@ public void setTags(Set<Tag> replacement) {
         tags.set(new UniqueTagList(replacement));
     }
 
-    /**
-     * Updates this person with the details of {@code replacement}.
-     */
-    public void resetData(ReadOnlyPerson replacement) {
-        requireNonNull(replacement);
-
-        this.setName(replacement.getName());
-        this.setPhone(replacement.getPhone());
-        this.setEmail(replacement.getEmail());
-        this.setAddress(replacement.getAddress());
-        this.setTags(replacement.getTags());
-    }
-
     @Override
     public boolean equals(Object other) {
         return other == this // short circuit if same object

src/main/java/seedu/address/model/person/UniquePersonList.java

@@ -48,11 +48,10 @@ public void add(ReadOnlyPerson toAdd) throws DuplicatePersonException {
     /**
      * Replaces the person {@code target} in the list with {@code editedPerson}.
      *
-     * @throws DuplicatePersonException if updating the person's details causes the person to be equivalent to
-     *      another existing person in the list.
+     * @throws DuplicatePersonException if the replacement is equivalent to another existing person in the list.
      * @throws PersonNotFoundException if {@code target} could not be found in the list.
      */
-    public void updatePerson(ReadOnlyPerson target, ReadOnlyPerson editedPerson)
+    public void setPerson(ReadOnlyPerson target, ReadOnlyPerson editedPerson)
             throws DuplicatePersonException, PersonNotFoundException {
         requireNonNull(editedPerson);
 
@@ -61,12 +60,11 @@ public void updatePerson(ReadOnlyPerson target, ReadOnlyPerson editedPerson)
             throw new PersonNotFoundException();
         }
 
-        Person personToUpdate = internalList.get(index);
-        if (!personToUpdate.equals(editedPerson) && internalList.contains(editedPerson)) {
+        if (!target.equals(editedPerson) && internalList.contains(editedPerson)) {
             throw new DuplicatePersonException();
         }
 
-        personToUpdate.resetData(editedPerson);
+        internalList.set(index, new Person(editedPerson));
     }
 
     /**