Skip to content

Commit 6e8398a

Browse files
authored
Merge pull request #32 from dchudik/master
Updated README. Fix install instruction. Added detailed instruction for developers.
2 parents 48a7f49 + 6e0047a commit 6e8398a

File tree

1 file changed

+14
-10
lines changed

1 file changed

+14
-10
lines changed

README.md

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,28 +6,28 @@ Cert-manager ACME DNS webhook provider for Selectel.
66

77
## Installing
88

9-
To install with helm, run:
9+
To install with helm in namespace: cert-manager, run:
1010

1111
```bash
1212
$ helm repo add selectel https://selectel.github.io/cert-manager-webhook-selectel
1313
$ helm repo update
14-
$ helm install --name cert-manager-webhook-selectel selectel/cert-manager-webhook-selectel
14+
$ helm install cert-manager-webhook-selectel selectel/cert-manager-webhook-selectel -n cert-manager
1515
```
1616

1717
OR
1818

1919
```bash
2020
$ git clone https://github.com/selectel/cert-manager-webhook-selectel.git
2121
$ cd cert-manager-webhook-selectel/deploy/cert-manager-webhook-selectel
22-
$ helm install --name cert-manager-webhook-selectel .
22+
$ helm install cert-manager-webhook-selectel . -n cert-manager
2323
```
2424

25-
Without helm, run:
25+
<!-- Without helm, run: -->
2626

27-
```bash
27+
<!-- ```bash
2828
$ make rendered-manifest.yaml
2929
$ kubectl apply -f _out/rendered-manifest.yaml
30-
```
30+
``` -->
3131

3232
### Issuer/ClusterIssuer
3333

@@ -38,6 +38,7 @@ apiVersion: v1
3838
kind: Secret
3939
metadata:
4040
name: selectel-api-key
41+
namespace: cert-manager
4142
type: Opaque
4243
stringData:
4344
token: APITOKEN_FROM_MY_SELECTEL_RU
@@ -46,7 +47,7 @@ apiVersion: cert-manager.io/v1
4647
kind: Issuer
4748
metadata:
4849
name: letsencrypt-staging
49-
namespace: default
50+
namespace: cert-manager
5051
spec:
5152
acme:
5253
server: https://acme-staging-v02.api.letsencrypt.org/directory
@@ -78,7 +79,7 @@ apiVersion: cert-manager.io/v1
7879
kind: Certificate
7980
metadata:
8081
name: sel-letsencrypt-crt
81-
namespace: default
82+
namespace: cert-manager
8283
spec:
8384
secretName: example-com-tls
8485
commonName: example.com
@@ -96,8 +97,11 @@ spec:
9697
9798
You can run the test suite with:
9899
99-
1. Go to `https://my.selectel.ru/profile/apikeys`, get one or create new api token
100-
2. Fill in the appropriate values in `testdata/selectel/apikey.yml` and `testdata/selectel/config.json`
100+
1. Go to `https://my.selectel.ru/profile/apikeys`, get one or create new api token.
101+
2. Fill in the appropriate values in `testdata/selectel/apikey.yml` and `testdata/selectel/config.json`.
102+
- Insert token `testdata/selectel/apikey.yml`.
103+
- Check that `metadata.name` in `testdata/selectel/apikey.yml` equals value in `testdata/selectel/config.json` for key `apiKeySecretRef.name`.
104+
- Check that key name in `testdata/selectel/apikey.yml` equals value in `testdata/selectel/config.json` for key `apiKeySecretRef.key`.
101105

102106
```bash
103107
$ TEST_ZONE_NAME=example.com. make test

0 commit comments

Comments
 (0)