doc: improve modelopt error description

[lianakoleva]

Motivation

Given that both --modelopt_quant and --quantization ServerArgs both exists, it may be helpful to the user to clarify how to set the ModelOpt quantization.

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

• Format your code according to the Format code with pre-commit.
• Add unit tests according to the Run and add unit tests.
• Update documentation according to Write documentations.
• Provide accuracy and speed benchmark results according to Test the accuracy and Benchmark the speed.

[gemini-code-assist]

Summary of Changes

Hello @lianakoleva, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the clarity of an error message related to ModelOpt quantization configuration. By providing more specific guidance within the error, it aims to reduce user confusion and streamline the process of setting up quantization options, particularly when dealing with potentially ambiguous command-line arguments.

Highlights

• Improved Error Message: The error message for quantize_and_serve requiring ModelOpt quantization has been enhanced to provide explicit instructions on how to set the quantization using the --quantization argument, including specific options like {modelopt, modelopt_fp8, modelopt_fp4}.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request improves an error message to be more helpful for users. The change is straightforward and correct. I've added one comment regarding code duplication which could be addressed to improve maintainability. Additionally, the test in test/srt/test_modelopt_export.py at line 243, test_quantize_and_serve_config_validation, should be updated to assert the new, more specific error message to ensure the test is robust.

[b8zhong]

Great work.