add spinner and raise questions

Author: julien-lang

python/tank/authentication/login_dialog.py

@@ -337,6 +337,27 @@ def __init__(
 
         self.confirm_box.setStyleSheet(self.styleSheet())
 
+
+        ## Init UI Spinner
+
+        self.ui.login.setVisible(False)
+        self.ui.password.setVisible(False)
+        # self.ui.message.setText("Retrieving the site information...")
+        self.__refresh_movie_icon = QtGui.QMovie(
+            os.path.join(
+                os.path.dirname(__file__),
+                "resources",
+                "spinning-wheel_40x40.gif",
+            )
+        )
+        if self.__refresh_movie_icon.loopCount() != -1:
+            self.__refresh_movie_icon.finished.connect(self.__refresh_movie_icon.start)
+
+        # movie.setLoopCount(-1)  # Loop forever
+        self.ui.message.setMovie(self.__refresh_movie_icon) # TODO create another widget for the spinner
+        self.__refresh_movie_icon.start()
+
+
     def __del__(self):
         """
         Destructor.
@@ -472,6 +493,7 @@ def _link_activated(self, site=None):
             )
 
     def _toggle_web(self, method_selected=None):
+        return
         """
         Sets up the dialog GUI according to the use of web login or not.
         """
@@ -701,13 +723,16 @@ def result(self):
 
             return self._sso_saml2.get_session_data()
 
-        # We want to wait until we know what is supported by the site, to avoid
-        # flickering GUI.
-        if not self._query_task.wait(THREAD_WAIT_TIMEOUT_MS):
-            logger.warning(
-                "Timed out awaiting requesting information: %s"
-                % self._get_current_site()
-            )
+        # # We want to wait until we know what is supported by the site, to avoid
+        # # flickering GUI.
+        # if not self._query_task.wait(THREAD_WAIT_TIMEOUT_MS):
+        #     logger.warning(
+        #         "Timed out awaiting requesting information: %s"
+        #         % self._get_current_site()
+        #     )
+
+        # Configure the GUI according to what we know: site and user preferences
+        # TODO ->        self._toggle_web....
 
         res = self.exec_()
         if res != QtGui.QDialog.Accepted:

python/tank/authentication/resources/spinning-wheel_40x40.gif

@@ -115,6 +115,14 @@ def reload(self, url, http_proxy=None):
             logger.debug("Unable to connect with %s, got exception '%s'", url, exc)
             return
 
+
+        # TODO emit a signal with the infos dict instead of waiting for the comsumer to retrieve it.
+        # Because the thread might already run with different URL at that point....
+
+
+        # ALSO, the following logs should only run if needed
+        # ALSO, why don't we consume the cache here ?!
+
         self._url = url
         self._infos = infos