Skip to content

Commit b477c42

Browse files
committed
Lower deposit finalization error to warning (#3739)
## Issue Addressed Partially addresses #3707 ## Proposed Changes Drop `ERRO` log to `WARN` until we identify the exact conditions that lead to this case. Add a message which hopefully reassures users who only see this log once 😅 Add the block hash to the error message in case it will prove useful in debugging the root cause.
1 parent e372953 commit b477c42

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

beacon_node/eth1/src/service.rs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -751,10 +751,11 @@ impl Service {
751751
let deposit_count_to_finalize = eth1data_to_finalize.deposit_count;
752752
if deposit_count_to_finalize > already_finalized {
753753
match self.finalize_deposits(eth1data_to_finalize) {
754-
Err(e) => error!(
754+
Err(e) => warn!(
755755
self.log,
756756
"Failed to finalize deposit cache";
757757
"error" => ?e,
758+
"info" => "this should resolve on its own"
758759
),
759760
Ok(()) => info!(
760761
self.log,
@@ -814,9 +815,10 @@ impl Service {
814815
.block_by_hash(&eth1_data.block_hash)
815816
.cloned()
816817
.ok_or_else(|| {
817-
Error::FailedToFinalizeDeposit(
818-
"Finalized block not found in block cache".to_string(),
819-
)
818+
Error::FailedToFinalizeDeposit(format!(
819+
"Finalized block not found in block cache: {:?}",
820+
eth1_data.block_hash
821+
))
820822
})?;
821823
self.inner
822824
.deposit_cache

0 commit comments

Comments
 (0)