Skip to content

Commit 8444969

Browse files
authored
choose different signature filename for KMS-signed release signatures (#4448)
* choose different signature filename for keyless release signatures Signed-off-by: Bob Callaway <[email protected]> * switch, rename the kms-signed objects Signed-off-by: Bob Callaway <[email protected]> * update README Signed-off-by: Bob Callaway <[email protected]> * update README Signed-off-by: Bob Callaway <[email protected]> --------- Signed-off-by: Bob Callaway <[email protected]>
1 parent 9b10de4 commit 8444969

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

.goreleaser.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ signs:
155155
- id: cosign
156156
cmd: ./dist/cosign-linux-amd64
157157
args: ["sign-blob", "--bundle", "${signature}", "--key", "gcpkms://projects/{{ .Env.PROJECT_ID }}/locations/{{ .Env.KEY_LOCATION }}/keyRings/{{ .Env.KEY_RING }}/cryptoKeys/{{ .Env.KEY_NAME }}/versions/{{ .Env.KEY_VERSION }}", "${artifact}"]
158-
signature: "${artifact}.sigstore.json"
158+
signature: "${artifact}-kms.sigstore.json"
159159
artifacts: binary
160160
# Keyless
161161
- id: cosign-keyless

README.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -761,8 +761,6 @@ will be released when there are breaking features.
761761
Should you discover any security issues, please refer to sigstore's [security
762762
process](https://github.com/sigstore/.github/blob/main/SECURITY.md)
763763
764-
## PEM files in GitHub Release Assets
764+
## Bundle files in GitHub Release Assets
765765
766-
The GitHub release assets for cosign contain a PEM file produced by [GoReleaser](https://github.com/sigstore/cosign/blob/ac999344eb381ae91455b0a9c5c267e747608d76/.goreleaser.yml#L166) while signing the cosign blob that is used to verify the integrity of the release binaries. This file is not used by cosign itself, but is provided for users who wish to verify the integrity of the release binaries.
767-
768-
By default, cosign output these PEM files in [base64 encoded format](https://github.com/sigstore/cosign/blob/main/doc/cosign_sign-blob.md#options), this approach might be good for air-gapped environments where the PEM file is stored in a file system. So, you should decode these PEM files before using them to verify the blobs.
766+
The GitHub release assets for `cosign` contain Sigstore bundle files produced by [GoReleaser](https://github.com/sigstore/cosign/blob/ac999344eb381ae91455b0a9c5c267e747608d76/.goreleaser.yml#L166) while signing the cosign blob that is used to verify the integrity of the release binaries. This file is not used by cosign itself, but is provided for users who wish to [verify the integrity of the release binaries](https://docs.sigstore.dev/cosign/system_config/installation/#verifying-cosign-with-artifact-key).

0 commit comments

Comments
 (0)