Skip to content

Commit bc1980b

Browse files
authored
Merge pull request #1063 from sigstore/dsse-version-fix
fix: Reject unsupported DSSE version
2 parents 9e26803 + 36b9486 commit bc1980b

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

sigstore-java/src/main/java/dev/sigstore/KeylessVerifier.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ private void checkMessageSignature(
339339
"Could not encode leaf certificate for comparison", e);
340340
}
341341
} else {
342-
throw new KeylessVerificationException("Unsupported hashedrekord version");
342+
throw new KeylessVerificationException("Unsupported hashedrekord version: " + version);
343343
}
344344
}
345345

@@ -505,6 +505,8 @@ private void checkDsseEnvelope(
505505
throw new KeylessVerificationException(
506506
"Could not encode leaf certificate for comparison", e);
507507
}
508+
} else {
509+
throw new KeylessVerificationException("Unsupported DSSE version: " + version);
508510
}
509511
}
510512
}

sigstore-java/src/test/java/dev/sigstore/KeylessVerifierTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -573,7 +573,7 @@ public void testVerify_unsupportedRekorVersion_rekorV2() throws Exception {
573573
Path.of(artifact),
574574
Bundle.from(new StringReader(invalidBundleFile)),
575575
VerificationOptions.empty()));
576-
Assertions.assertEquals("Unsupported hashedrekord version", ex.getMessage());
576+
Assertions.assertEquals("Unsupported hashedrekord version: 0.0.3", ex.getMessage());
577577
}
578578

579579
@Test

0 commit comments

Comments
 (0)