Add Filter type
#1183
Open
Add Filter type
#1183
+542
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion to `IsLeadingRestElement`
1 task
|
Needs to be added to readme and index.d.ts |
|
Make sure to go through the pull request yourself and the diff and find mistakes. Etc. AI can be helpful for this. |
benzaria
commented
Sep 27, 2025
|
Just pointing out that we also could merge them in one |
|
A single type is tempting. Any downsides? |
should not be any, I guess. |
|
@sindresorhus the merge of both types was flawless with no problems. |
Removed duplicate lines in type documentation.
source/internal/array.d.ts
Outdated
| type Fail2 = IsEmptyArray<[0?]>; | ||
| //=> false | ||
| type Fail3 = IsEmptyArray<...string[]>; |
There was a problem hiding this comment.
I don't think this is valid TS. Ensure all examples are correct.
There was a problem hiding this comment.
You're right, I fixed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1181
Filters elements from an
Array/Objectbased on whether there members match the givenType.If
TypeisBoolean, it filters outfalsyvalues likeBoolean(T)does.Strict controls whether strict or loose type comparison is used (defaults to loose). I will add this as on option eventually!