Skip to content

Commit c207c3e

Browse files
authored
do not change instance name (#216)
* do not change instance name * pre-formating done * bump version to 0.3.13 * document changes Co-authored-by: Eric DEVEAUD <[email protected]>
1 parent 29c7d36 commit c207c3e

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ The client here will eventually be released as "spython" (and eventually to
1717
singularity on pypi), and the versions here will coincide with these releases.
1818

1919
## [master](https://github.com/singularityhub/singularity-cli/tree/master)
20+
- do not modify user provided instance name when generating new instance (0.3.13)
2021
- bug with instance.run_command (0.3.12)
2122
- added check to enbsure stderr exists upon a non-zero return code when streaming (0.3.11)
2223
- exposed the stream type option, and ability to capture both stdout and stderr when stream=True (0.3.1)

spython/instance/__init__.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,10 @@ def generate_name(self, name=None):
4747
# If no name provided, use robot name
4848
if name is None:
4949
name = self.RobotNamer.generate()
50-
self.name = name.replace("-", "_")
50+
# dash allowed in instance name.
51+
# authorizedChars = `^[a-zA-Z0-9._-]+$` from instance_linux.go
52+
# self.name = name.replace("-", "_")
53+
self.name = name
5154

5255
def parse_image_name(self, image):
5356
"""

spython/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
# with this file, You can obtain one at http://mozilla.org/MPL/2.0/.
66

77

8-
__version__ = "0.3.12"
8+
__version__ = "0.3.13"
99
AUTHOR = "Vanessa Sochat"
1010
AUTHOR_EMAIL = "[email protected]"
1111
NAME = "spython"

0 commit comments

Comments
 (0)