Skip to content

Commit 48d5d9d

Browse files
committed
fix: Fix minor issues of backend
1 parent 73180f3 commit 48d5d9d

File tree

4 files changed

+9
-6
lines changed

4 files changed

+9
-6
lines changed

backend/problem/serializers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ class BaseProblemSerializer(serializers.ModelSerializer):
131131
def get_contest_name(self, obj):
132132
if obj.contest:
133133
return obj.contest.title
134-
134+
135135
def get_assignment_name(self, obj):
136136
if obj.assignment:
137137
return obj.assignment.title

backend/problem/tests.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -275,12 +275,12 @@ def setUp(self):
275275

276276
def test_get_assignment_problem_list(self):
277277
self.test_create_assignment_problem()
278-
res = self.client.get(f"{self.url}?assignment_id={self.assignment_id}")
278+
res = self.client.get(f"{self.url}?course_id={self.course_id}&assignment_id={self.assignment_id}")
279279
self.assertSuccess(res)
280280

281281
def test_get_assignment_problem(self):
282282
problem_id = self.test_create_assignment_problem()["id"]
283-
res = self.client.get(f"{self.url}?assignment_id={self.assignment_id}&problem_id={problem_id}")
283+
res = self.client.get(f"{self.url}?course_id={self.course_id}&assignment_id={self.assignment_id}&problem_id={problem_id}")
284284
self.assertSuccess(res)
285285

286286
def test_create_assignment_problem(self):

backend/problem/views/professor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ def get(self, request):
283283
@admin_role_required
284284
def post(self, request):
285285
data = request.data
286-
286+
287287
try:
288288
course = Course.objects.get(id=data.pop("course_id"))
289289
ensure_created_by(course, request.user)

backend/submission/views.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
from drf_yasg import openapi
55

66
from assignment.models import Assignment
7-
from course.models import Course
87
from contest.models import ContestStatus, ContestRuleType
98
from judge.tasks import judge_task
109
from options.options import SysOptions
@@ -78,7 +77,11 @@ def post(self, request):
7877
return self.error(error)
7978

8079
try:
81-
problem = Problem.objects.get(id=data["problem_id"], contest_id=data.get("contest_id"), assignment_id=data.get("assignment_id"), course_id=data.get("course_id"), visible=True)
80+
problem = Problem.objects.get(id=data["problem_id"],
81+
contest_id=data.get("contest_id"),
82+
assignment_id=data.get("assignment_id"),
83+
course_id=data.get("course_id"),
84+
visible=True)
8285
except Problem.DoesNotExist:
8386
return self.error("Problem not exist")
8487
if data["language"] not in problem.languages:

0 commit comments

Comments
 (0)