Update igmarkets.go #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed max=100 as it overwrites the max value when calling GetPriceHistory
|
Thanks for looking into that! I guess we can remove the |
markusvanlaak
commented
Apr 13, 2020
| toStr := to.Format("2006-01-02T15:04:05") | ||
| limitStr = fmt.Sprintf("&from=%s&to=%s", fromStr, toStr) | ||
| } else if max > 0 { | ||
| limitStr = fmt.Sprintf("&max=%d", max) |
There was a problem hiding this comment.
max is set only when "to" or "from" has no time.Time value.
GetPriceHistory requires time.Time so it will never set "max" in the "else if" to 1.
Setting max is required to not get the default of i think 10.
There was a problem hiding this comment.
What I mean is: If max > 0, we set max twice. In page and in limitStr. This is wrong IMO because both are used to assemble the URL. I think we need to removed it from page and leave limitStr empty if max is zero.
sklinkert
reviewed
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed max=100 as it overwrites the max value when calling GetPriceHistory