Clearify error message if user tries to uninstall a nonkube site.

Author: lynnemorrison

internal/cmd/skupper/system/nonkube/system_uninstall.go

@@ -3,6 +3,7 @@ package nonkube
 import (
 	"errors"
 	"fmt"
+	"net"
 	"os"
 	"path"
 
@@ -99,7 +100,12 @@ func (cmd *CmdSystemUninstall) Run() error {
 	err := cmd.SystemUninstall(string(config.GetPlatform()))
 
 	if err != nil {
-		return fmt.Errorf("failed to uninstall : %s", err)
+		opErr := &net.OpError{}
+		if errors.As(err, &opErr) {
+			return fmt.Errorf("Unable to communicate with the Container Engine.\nRun: \"skupper system install\" to prepare the local environment and start the controller.\n\nError: %s", err)
+		} else {
+			return fmt.Errorf("Unable to uninstall.\nError: %s", err.Error())
+		}
 	}
 
 	return nil

internal/cmd/skupper/system/nonkube/system_uninstall_test.go

@@ -2,6 +2,7 @@ package nonkube
 
 import (
 	"fmt"
+	"net"
 	"os"
 	"path/filepath"
 	"testing"
@@ -139,7 +140,7 @@ func TestCmdSystemUninstall_Run(t *testing.T) {
 		{
 			name:               "disable socket fails",
 			disableSocketFails: true,
-			errorMessage:       "failed to uninstall : disable socket fails",
+			errorMessage:       "Unable to communicate with the Container Engine.\nRun: \"skupper system install\" to prepare the local environment and start the controller.\n\nError: dial: disable socket fails",
 			flags:              &common.CommandSystemUninstallFlags{Force: false},
 		},
 	}
@@ -235,7 +236,11 @@ func newCmdSystemUninstallWithMocks(disableSocketFails bool) *CmdSystemUninstall
 
 func mockCmdSystemUninstall(platform string) error { return nil }
 func mockCmdSystemUninstallDisableSocketFails(platform string) error {
-	return fmt.Errorf("disable socket fails")
+	errMsg := fmt.Errorf("disable socket fails")
+	netErr := &net.OpError{
+		Op:  "dial",
+		Err: errMsg}
+	return netErr
 }
 
 func mockCmdSystemUninstallThereAreStillSites() (bool, error)    { return true, nil }

internal/nonkube/bootstrap/uninstall.go

@@ -2,6 +2,7 @@ package bootstrap
 
 import (
 	"fmt"
+	"net"
 	"os"
 	"os/user"
 	"path"
@@ -44,7 +45,11 @@ func Uninstall(platform string) error {
 
 	cli, err := internalclient.NewCompatClient(endpoint, "")
 	if err != nil {
-		return fmt.Errorf("failed to create container client: %v", err)
+		errMsg := fmt.Errorf("failed to create container client: %v", err)
+		netErr := &net.OpError{
+			Op:  "dial",
+			Err: errMsg}
+		return netErr
 	}
 
 	container, err := cli.ContainerInspect(containerName)