Skip to content

Fixes the lifecycle of the PodWatcher used by AttachedConnectors #2321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fgiorgetti wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fixes the lifecycle of the PodWatcher used by AttachedConnectors #2321

fgiorgetti wants to merge 4 commits into from

Conversation

@fgiorgetti
Copy link
Member

@fgiorgetti fgiorgetti commented Nov 20, 2025 •
edited
Loading

Proper control to the lifecycle of a PodWatcher used by AttachedConnectors when:

  • Site is deleted and re-created
  • AttachedConnector.spec.siteNamespace changes
  • AttachedConnectorBinding.spec.connectorNamespace changes
  • AttachedConnector is deleted
  • AttachedConnectorBinding is deleted
  • Avoid unnecessary updates to the skupper-router configmap on podwatcher events (for attached connectors)
  • Unit tests

Fixes #2320.

@fgiorgetti fgiorgetti marked this pull request as ready for review November 21, 2025 21:32
@fgiorgetti fgiorgetti requested a review from ajssmith November 24, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@c-kruse c-kruse Awaiting requested review from c-kruse c-kruse is a code owner

@nluaces nluaces Awaiting requested review from nluaces nluaces is a code owner

@ajssmith ajssmith Awaiting requested review from ajssmith

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tcp Connectors gets deleted and created indefinitely

1 participant

@fgiorgetti