try to make certificate addition/removal reloadable in some cases #1468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackDoan
commented
Sep 8, 2025
JackDoan
force-pushed
the
cert-v2-reloads
branch
from
73e7946 to
a8b091c
Compare
JackDoan
commented
Sep 10, 2025
JackDoan
force-pushed
the
cert-v2-reloads
branch
2 times, most recently
from
345ceef to
eb5954f
Compare
nbrownus
reviewed
Oct 2, 2025
nbrownus
reviewed
Oct 2, 2025
nbrownus
reviewed
Oct 2, 2025
nbrownus
reviewed
Oct 2, 2025
nbrownus
reviewed
Oct 2, 2025
nbrownus
reviewed
Oct 2, 2025
nbrownus
reviewed
Oct 2, 2025
…ot match with a cert that we can indeed match
…sion than our peer, and we have a newer-version cert available
JackDoan
force-pushed
the
cert-v2-reloads
branch
from
eb5954f to
dc3081e
Compare
…unnels (this is fine as long as we don't let you change your set of vpnNetworks on reload)
nbrownus
reviewed
Oct 2, 2025
nbrownus
reviewed
Oct 7, 2025
JackDoan
commented
Oct 9, 2025
wadey
previously approved these changes
Oct 28, 2025
Member
wadey
left a comment
wadey
left a comment
There was a problem hiding this comment.
Overall I think this change makes sense and does what it says, does Nate give final approve after his comments?
nbrownus
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.