Skip to content

ENH: Actions + Linting Changes #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
YektaY wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

ENH: Actions + Linting Changes #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
855ed36
wip-switched to aribnb style guide, started addressing style guide er…
YektaY Jan 28, 2026
917495d
FIX: finished clearing lint errors and warnings
YektaY Jan 28, 2026
3871a87
FIX: addressed style issues
YektaY Jan 28, 2026
3c6e10f
FIX: addressed a typescript type error
YektaY Jan 28, 2026
7c3fb9a
ENH: update to husky
YektaY Jan 28, 2026
99492a5
FIX: strange bug where tag groups were moving about. introduced with …
YektaY Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions .eslintrc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,20 @@ module.exports = {
root: true,
env: { browser: true, es2020: true },
extends: [
'eslint:recommended',
'airbnb',
'airbnb-typescript',
'airbnb/hooks',
'plugin:@typescript-eslint/recommended',
'plugin:react/recommended',
'plugin:react/jsx-runtime',
'plugin:react-hooks/recommended',
'prettier',
],
ignorePatterns: ['dist', '.eslintrc.cjs'],
ignorePatterns: ['dist', '.eslintrc.cjs', 'vite.config.ts', '**/__tests__/**', '**/*.test.ts', '**/*.test.tsx'],
parser: '@typescript-eslint/parser',
parserOptions: {
ecmaVersion: 'latest',
sourceType: 'module',
project: './tsconfig.json',
ecmaFeatures: {
jsx: true,
},
Expand All @@ -25,8 +27,17 @@ module.exports = {
},
},
rules: {
// React 17+ doesn't require React import
'react/react-in-jsx-scope': 'off',
// Allow TypeScript for prop types
'react/prop-types': 'off',
'react/require-default-props': 'off',
// Unused vars with underscore prefix are allowed
'@typescript-eslint/no-unused-vars': ['warn', { argsIgnorePattern: '^_' }],
'@typescript-eslint/no-explicit-any': 'warn',
// Allow named exports without default
'import/prefer-default-export': 'off',
// Allow devDependencies in config files
'import/no-extraneous-dependencies': ['error', { devDependencies: true }],
},
};
34 changes: 34 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: Lint & Format

on:
push:
branches: [main]
pull_request:
branches: [main]

jobs:
lint:
name: ESLint & Prettier
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '20'
cache: 'npm'

- name: Install dependencies
run: npm ci

- name: Run ESLint
run: npm run lint

- name: Check Prettier formatting
run: npm run format:check

- name: TypeScript type check
run: npx tsc --noEmit
22 changes: 0 additions & 22 deletions .github/workflows/standard.yml
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

# Run TypeScript type checking
npx tsc --noEmit

# Run lint-staged (eslint + prettier on staged files)
npx lint-staged
Loading
Loading