Skip to content

Commit 8ef68d5

Browse files
committed
Fix canary to use latest dependency versions from PRs
The canary was using stale dependency versions from committed Cargo.lock files instead of the versions specified in PRs. This caused the canary to miss the crc-fast 1.4 SIGILL issue. Solution: Delete workspace Cargo.lock files before running the canary to force fresh dependency resolution. This ensures the canary tests the exact dependency versions from the PR. Fixes #3981
1 parent 34aaa4b commit 8ef68d5

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

tools/ci-scripts/run-canary

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,13 @@ export RUST_LOG=debug
1515

1616
SDK_PATH="$(pwd)/aws-sdk/sdk"
1717

18+
# Delete workspace Cargo.lock files to ensure fresh dependency resolution.
19+
# This ensures the canary uses the exact dependency versions from the PR,
20+
# not stale versions from a committed lock file.
21+
# See: https://github.com/smithy-lang/smithy-rs/issues/3981
22+
rm -f smithy-rs/rust-runtime/Cargo.lock
23+
rm -f smithy-rs/aws/rust-runtime/Cargo.lock
24+
1825
cd smithy-rs/tools/ci-cdk/canary-runner
1926
aws s3 cp s3://"${CANARY_STACK_CDK_OUTPUTS_BUCKET_NAME}"/cdk-outputs.json .
2027
cargo run -- \

0 commit comments

Comments
 (0)