Replace "validation" provider with check blocks

[lorengordon]

As of Terraform 1.5, there are check blocks that I believe offer the functionality that the "validation" resources are being used for, but without requiring the addition of a third-party provider.

• https://developer.hashicorp.com/terraform/language/checks

[peterdeme]

Are you talking about this resource?

terraform-aws-spacelift-workerpool-on-ec2/secure_strings.tf

Line 18 in fecb535

resource "validation_warning" "token_or_private_key_in_plaintext" {

Wouldn't the Tf-native check block fail the run instead of just printing a warning?

[lorengordon]

Are you talking about this resource?

terraform-aws-spacelift-workerpool-on-ec2/secure_strings.tf

Line 18 in fecb535

resource "validation_warning" "token_or_private_key_in_plaintext" {
Wouldn't the Tf-native check block fail the run instead of just printing a warning?

Negative. Check blocks due not affect Terraform execution. See the section on assertions, https://developer.hashicorp.com/terraform/language/checks#assertions:

Unlike other custom conditions, assertions do not affect Terraform's execution of an operation. A failed assertion reports a warning without halting the ongoing operation. This contrasts with other custom conditions, such as a postcondition, where Terraform produces an error immediately, halting the operation and blocking the application or planning of future resources.

[peterdeme]

Fair enough. The only minor issue I see with the approach is that it's only supported from TF 1.5 which might be a bit too restrictive. Otherwise it's definitely a better solution.

[lorengordon]

I mean, how old is TF 1.5 now? Over two years ago? 😉 Gotta draw a line somewhere!