Commit 8447e09
Fix OIDC docs to include the entire space ID.
The JWTs issued by Spacelift actually contain the entire space ID, not
just the name. This means that the previously documented conditions for
AWS and Azure do not match the actual `sub`.
For example, following the old example to restrict the role to a
particular space by name:
```
"StringLike": {
"demo.app.spacelift.io:sub": "space:production:*"
}
```
This does not match the actual JWT subject, which looks like this:
```
space:production-01HND497T9JKR76MR3KA2CDJHP:stack:my-stack:run_type:PROPOSED:scope:read
```
I'm not sure if this ID format changed at some point. (Maybe
historically space IDs did not have a random suffix?) From what I can
see, all spaces have a random ID except the special root space (ID
`root`).
The docs page for GCP seems to correctly show the full space ID already.1 parent dcc9b6a commit 8447e09
File tree
3 files changed
+17
-12
lines changed- docs/integrations/cloud-providers/oidc
3 files changed
+17
-12
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
| 69 | + | |
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
| 62 | + | |
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
| 66 | + | |
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
83 | 88 | | |
84 | 89 | | |
85 | 90 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
60 | | - | |
| 59 | + | |
| 60 | + | |
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| |||
0 commit comments