Condition PolySharp for only netstandard2.0
#1934
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/sdk#51430 Context: dotnet/source-build-reference-packages#1447 We would like to use Spectre.Console for the `dotnet` CLI, and .NET has to be able to be completely built from source. It would help us to have `PolySharp` only included when building for `netstandard2.0`, as that is the only target framework that needs the polyfills. .NET would probably only use the latest target framework. Thanks!
|
just saw @patriksvensson is moving Spectre.Console.Cli to a new repo in #1928 so I guess we'll need to pick that up as well once it's merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I did not file this on an issue, but the change is trivial, so I thought we could discuss here. Thanks!
Changes
Context: dotnet/sdk#51430
Context: dotnet/source-build-reference-packages#1447
We would like to use Spectre.Console for the
dotnetCLI, and .NET has to be able to be completely built from source.It would help us to have
PolySharponly included when building fornetstandard2.0, as that is the only target framework that needs the polyfills..NET would probably only build the latest target framework.
Thanks!