Skip to content

logo_name = None not handled properly, appears in sidebar #216

@sloria

Description

@sloria

Related to the fix for #215 in 39cbbc1 .

I worked around the previous issue #215 by setting logo_name to None in html_theme_options:

html_theme_options = {
    "logo": "marshmallow-logo.png",
    "logo_name": None,
    # ...
}

but when I upgrade to alabaster 0.7.16, None appears in the sidebar

Firefox 2024-01-18 at 12 45 36

This is easily fixed by removing the logo_name setting, but the template should also properly handle None.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions